Grant rustfmt team write access to rust-lang/rust
#1948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustfmt team already has bors r+ permissions on `rust-lang/rust`, they should receive write access too, otherwise weird situations like "rustfmt team members can approve a PR, but can't even get assigned" happens.
jieyouxu
requested review from
Mark-Simulacrum,
pietroalbini,
jdno and
marcoieni
as code owners
jieyouxu
added
needs-infra-admin-review
Dry-run check results |
Mark-Simulacrum
approved these changes
Aug 15, 2025
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustfmt team already has bors r+ permissions on
rust-lang/rust.team/teams/rustfmt.toml
Lines 19 to 21 in b10e726
They should receive write access too, otherwise weird situations like "rustfmt team members can approve a PR, but can't even get assigned" happens. Noticed this in rust-lang/rust#144323 (comment). Same thing as #1841 (but that was for r-a team).
cc @ytmimi
calebcartwright was assignable already because both testing-devex and style teams have write access to r-l/r already, and they're a member of those teams.
FYI @rust-lang/rustfmt
cc #1842