Skip to content

Conversation

@jieyouxu
Copy link
Member

The https://github.com/rust-analyzer/smol_str repo permissions are also managed through the team repo, so manually granted write access will be lost on a permission sync (see #2030 (comment)).

This PR creates a new marker team smol-str mimicking expect-test's approach1

name = "expect-test"
to restore write access to @alexheretic (who I believe was invited to collaborate onsmol_str but was added not through team repo).

Discussion: #t-infra > rust-analyer/smol_str permissions

This needs a co-lead approval from the parent team (rust-analyzer) so cc @Veykril. Please let me know if this is the intended permission setup.

Footnotes

  1. Note that expect-test is not a proper rust-analyzer subteam but a marker team, not sure if that's intended or not. I chose to follow the existing approach to restore the lost write access.

@jieyouxu jieyouxu added needs-team-repo-admin-review This change requires one of the `team-repo-admins` to review. needs-team-lead-review This change requires a team/WG/PG lead to review. S-waiting-on-team Status: waiting on team labels Oct 24, 2025
@github-actions
Copy link

Dry-run check results

[WARN  sync_team] sync-team is running in dry mode, no changes will be applied.
[INFO  sync_team] synchronizing github
[INFO  sync_team] 💻 Team Diffs:
    ➕ Creating team:
      Org: rust-analyzer
      Name: smol-str
      Description: Managed by the rust-lang/team repository.
      Privacy: closed
      Members:
        alexheretic: member
    💻 Repo Diffs:
    📝 Editing repo 'rust-analyzer/smol_str':
      Permission Changes:
        Giving team 'smol-str' write permission

Comment on lines +1 to +2
name = "smol-str"
kind = "marker-team"
Copy link
Member Author

@jieyouxu jieyouxu Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark: ah, @ehuss had the reasonable concern where we probably shouldn't be using marker teams for actual permissions (i.e. this should be a proper subteam).

If you are onboard with making expect-test and smol-str proper subteams of r-a, I can also do that @Veykril.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I would prefer to avoid using marker teams for anything like this. I think it's fine to create a real team. The charter can be something as simple as "Responsible for maintaining and updating the smol-str crate."

Copy link
Member Author

@jieyouxu jieyouxu Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll change this to charter a proper r-a smol-str subteam, and if Lukas is in favor, we can recharter the expect-test marker team into a proper r-a subteam as well.

EDIT: holding off in case r-a wants a -crates team #2036 (comment)

@jieyouxu jieyouxu added S-waiting-on-author Status: waiting on PR author and removed S-waiting-on-team Status: waiting on team labels Oct 24, 2025
@jackh726
Copy link
Member

An alternative for the rust-analyzer team: rather than making separate teams for these (and future) crates, maybe just make a rust-analyzer-crates team?

@jieyouxu jieyouxu added S-waiting-on-team Status: waiting on team and removed S-waiting-on-author Status: waiting on PR author labels Oct 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-team-lead-review This change requires a team/WG/PG lead to review. needs-team-repo-admin-review This change requires one of the `team-repo-admins` to review. S-waiting-on-team Status: waiting on team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants