- 
                Notifications
    You must be signed in to change notification settings 
- Fork 326
          Create smol-str marker team for rust-analyzer/smol_str
          #2036
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| Dry-run check results | 
| name = "smol-str" | ||
| kind = "marker-team" | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, I would prefer to avoid using marker teams for anything like this. I think it's fine to create a real team. The charter can be something as simple as "Responsible for maintaining and updating the smol-str crate."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll change this to charter a proper r-a smol-str subteam, and if Lukas is in favor, we can recharter the expect-test marker team into a proper r-a subteam as well.
EDIT: holding off in case r-a wants a -crates team #2036 (comment)
| An alternative for the rust-analyzer team: rather than making separate teams for these (and future) crates, maybe just make a  | 
The https://github.com/rust-analyzer/smol_str repo permissions are also managed through the
teamrepo, so manually granted write access will be lost on a permission sync (see #2030 (comment)).This PR creates a new marker team
smol-strmimickingexpect-test's approach1team/teams/expect-test.toml
Line 1 in d6a865c
smol_strbut was added not throughteamrepo).Discussion: #t-infra > rust-analyer/smol_str permissions
This needs a co-lead approval from the parent team (rust-analyzer) so cc @Veykril. Please let me know if this is the intended permission setup.
Footnotes
Note that
expect-testis not a properrust-analyzersubteam but a marker team, not sure if that's intended or not. I chose to follow the existing approach to restore the lost write access. ↩