- 
                Notifications
    You must be signed in to change notification settings 
- Fork 326
          Mention rust_team_data usage when changing it
          #2047
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| Thanks, this is a good idea, and sorry for the breakage. Next time we should mark the field with  | 
| Dry-run check results | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this doesn't need write access, this looks good to me, thanks.
| Actually, could you also update https://github.com/rust-lang/team/blob/master/docs/labels.md#labels-are-currently-manually-applied to say that only limited functionality from triagebot is available because triagebot doesn't have write access to this repo? (Since technically now triagebot is setup, just that it can't support the "fancier" functionality). | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
| CI failure is unrelated, it's because 
 UPD: #2048 should unblock this PR once that merges. | 
This PR adds a triagebot mention to changes done to the v1 format of
rust_team_data, as it's being used by multiple projects and breaking the format results in an outage of some functionality.See #triagebot > ✔ assign handler, error decoding response body? for the last one #2043.
Note that "triagebot is currently not setup in this repo, as it would need write access (which needs to be tightly controlled)"1, which is fair for this repo. Fortunately posting a comment on this repo doesn't need write access so we should be fine.
cc @Kobzol @senekor (as you were also impacted)
Footnotes
https://github.com/rust-lang/team/blob/master/docs/labels.md#labels-are-currently-manually-applied ↩