Skip to content

Conversation

@Urgau
Copy link
Member

@Urgau Urgau commented Oct 29, 2025

This PR adds a triagebot mention to changes done to the v1 format of rust_team_data, as it's being used by multiple projects and breaking the format results in an outage of some functionality.

See #triagebot > ✔ assign handler, error decoding response body? for the last one #2043.

Note that "triagebot is currently not setup in this repo, as it would need write access (which needs to be tightly controlled)"1, which is fair for this repo. Fortunately posting a comment on this repo doesn't need write access so we should be fine.

cc @Kobzol @senekor (as you were also impacted)

Footnotes

  1. https://github.com/rust-lang/team/blob/master/docs/labels.md#labels-are-currently-manually-applied

@Kobzol
Copy link
Member

Kobzol commented Oct 29, 2025

Thanks, this is a good idea, and sorry for the breakage. Next time we should mark the field with Option, then update the projects, and remove it and then update the projects again.

@github-actions
Copy link

Dry-run check results

[WARN  sync_team] sync-team is running in dry mode, no changes will be applied.
[INFO  sync_team] synchronizing github

jieyouxu
jieyouxu previously approved these changes Oct 30, 2025
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this doesn't need write access, this looks good to me, thanks.

@jieyouxu jieyouxu added S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin. T-infra Relevant to the infrastructure team. labels Oct 30, 2025
@jieyouxu
Copy link
Member

Actually, could you also update https://github.com/rust-lang/team/blob/master/docs/labels.md#labels-are-currently-manually-applied to say that only limited functionality from triagebot is available because triagebot doesn't have write access to this repo? (Since technically now triagebot is setup, just that it can't support the "fancier" functionality).

@jieyouxu jieyouxu self-assigned this Oct 30, 2025
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu
Copy link
Member

jieyouxu commented Oct 30, 2025

CI failure is unrelated, it's because

[ERROR rust_team::validate] validation error: GitHub user Osintedx changed username to iownrena

UPD: #2048 should unblock this PR once that merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin. T-infra Relevant to the infrastructure team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants