Skip to content

rulesets: log when default fields change - #2385

Merged
marcoieni merged 1 commit into
mainfrom
rulesets-log-when-default-fields-change
Apr 7, 2026
Merged

rulesets: log when default fields change#2385
marcoieni merged 1 commit into
mainfrom
rulesets-log-when-default-fields-change

Conversation

@marcoieni

@marcoieni marcoieni commented Apr 7, 2026

Copy link
Copy Markdown
Member

Fix #2376

I also convert crates.io-index-archive to prove that this PR works. In fact, the dry run now shows prevent-creation = false

@github-actions

github-actions Bot commented Apr 7, 2026

Copy link
Copy Markdown
Dry-run check results

[WARN  rust_team::sync] sync-team is running in dry mode, no changes will be applied.
[INFO  rust_team::sync] synchronizing crates-io
[INFO  rust_team::sync] synchronizing github
[INFO  rust_team::sync] 💻 Repo Diffs:
    📝 Editing repo 'rust-lang/crates.io-index-archive':
      Branch Protections:
          main
            Deleting branch protection
          snapshot-*
            Deleting branch protection
      Rulesets:
          Creating 'snapshot-*'
            Include Branches: ["refs/heads/snapshot-*"]
            Require pull requests: false
            Restrict creations: false
          Creating 'main'
            Include Branches: ["refs/heads/main"]
            Require pull requests: false

@marcoieni
marcoieni force-pushed the rulesets-log-when-default-fields-change branch from b7caec8 to f3054dd Compare April 7, 2026 10:19
@marcoieni
marcoieni force-pushed the rulesets-log-when-default-fields-change branch from f3054dd to 70d19bc Compare April 7, 2026 10:26
@marcoieni
marcoieni marked this pull request as ready for review April 7, 2026 10:31

@ubiratansoares ubiratansoares left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This additional logging definitely helps 🙂

@marcoieni
marcoieni added this pull request to the merge queue Apr 7, 2026
Merged via the queue into main with commit 41fdc7d Apr 7, 2026
3 checks passed
@marcoieni
marcoieni deleted the rulesets-log-when-default-fields-change branch April 22, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ruleset dry run diff doesn't show some booleans

2 participants