rulesets: log when default fields change - #2385
Merged
Merged
Conversation
Dry-run check results |
marcoieni
force-pushed
the
rulesets-log-when-default-fields-change
branch
from
April 7, 2026 10:19
b7caec8 to
f3054dd
Compare
marcoieni
force-pushed
the
rulesets-log-when-default-fields-change
branch
from
April 7, 2026 10:26
f3054dd to
70d19bc
Compare
marcoieni
marked this pull request as ready for review
April 7, 2026 10:31
marcoieni
requested review from
Mark-Simulacrum,
emilyalbini,
jdno and
ubiratansoares
as code owners
April 7, 2026 10:31
ubiratansoares
approved these changes
Apr 7, 2026
ubiratansoares
left a comment
Contributor
There was a problem hiding this comment.
This additional logging definitely helps 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2376
I also convert
crates.io-index-archiveto prove that this PR works. In fact, the dry run now showsprevent-creation = false