Remove deprecated items .all_close() and DataClone, ArrayView::into_slice
#874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Data + RawDataClone as replacement
bluss
changed the title
ArrayView::into_slice.all_close() and DataClone, un-deprecate ArrayView::into_slice
Replaced by .abs_diff_eq (using the approx feature)
bluss
force-pushed
the
process-deprecations
branch
from
721263f to
ca691c5
Compare
|
The ArrayView::to_slice/into_slice situation: it's not clear cut, it could swing both ways, but to me the |
This could really use either name - `into_slice` for the "into" semantic of preserving the lifetime parameter, or the `to_slice` name which is customary for `&self` methods. Both names have the problem that they compete with `ArrayBase::as_slice()`, but the doc has been improved to explain some of that.
bluss
changed the title
.all_close() and DataClone, un-deprecate ArrayView::into_slice.all_close() and DataClone, ArrayView::into_slice
bluss
force-pushed
the
process-deprecations
branch
from
1ec4142 to
e071bdb
Compare
|
I changed my mind about keeping into_slice. It's really a toss-up which is best between into_slice and to_slice. I'd prefer into_slice, but it's too churny to reverse the deprecation, so I also prefer to not do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.all_close()- use approx feature and methods like.abs_diff_eqinstead.scalar_sum()as deprecated - use.sum()insteadDataClone- useData + RawDataCloneinsteadArrayView::into_slice- useto_slice()instead.Fixes #863
ArrayView::into_slicevsto_sliceLooking closely at this one, I'd want to use the name
into_slice.The "into" semantic is for preserving the lifetime from the input
to the output - and for setting it more apart from the general
ArrayBase::as_slice.However, both names
into-sliceandto-slicehave pros and consand in the interest of reducing churn, the already deprecated method
loses in the tiebreaker IMO, and so
into_sliceis removed becauseclippy said so.
Previously in #646