Skip to content

DO NOT MERGE: Demonstrate lacking test coverage #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

DO NOT MERGE: Demonstrate lacking test coverage #163

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30a511f
DO NOT MERGE: Demonstrate lacking test coverage
tyll Apr 15, 2025
bb938b6
Example doc tests for MinMtu
tyll Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions src/link/attribute.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,22 @@ pub enum LinkAttribute {
GsoMaxSegs(u32),
GsoMaxSize(u32),
/// The minimum MTU for the device.
MinMtu(u32),
///```
/// # use netlink_packet_route::link::LinkAttribute;
/// let _link_attribute: LinkAttribute = LinkAttribute::MinMtu(0);
/// let _link_attribute: LinkAttribute = LinkAttribute::MinMtu(0xffff_ffff);
///```
/// ```compile_fail
/// # use netlink_packet_route::link::LinkAttribute;
/// # fn test_min_mtu() {}
/// let _link_attribute: LinkAttribute = LinkAttribute::MinMtu(-1);
/// ```
/// ```compile_fail
/// # use netlink_packet_route::link::LinkAttribute;
/// # fn test_min_mtu() {}
/// let _link_attribute: LinkAttribute = LinkAttribute::MinMtu(0x1_0000_0000);
/// ```
MinMtu(i32),
/// The maximum MTU for the device.
MaxMtu(u32),
LinkNetNsId(i32),
Expand Down Expand Up @@ -284,8 +299,11 @@ impl Nla for LinkAttribute {
| Self::CarrierDownCount(value)
| Self::GsoMaxSegs(value)
| Self::GsoMaxSize(value)
| Self::MinMtu(value)
| Self::MaxMtu(value) => NativeEndian::write_u32(buffer, *value),
=> NativeEndian::write_u32(buffer, *value),

Self::MinMtu(value) => NativeEndian::write_i32(buffer, *value),

Self::MaxMtu(value) => NativeEndian::write_u32(buffer, *value),

Self::ExtMask(value) => NativeEndian::write_u32(
buffer,
Expand Down Expand Up @@ -598,7 +616,7 @@ impl<'a, T: AsRef<[u8]> + ?Sized>
.context("invalid IFLA_GSO_MAX_SIZE value")?,
),
IFLA_MIN_MTU => Self::MinMtu(
parse_u32(payload).context("invalid IFLA_MIN_MTU value")?,
parse_i32(payload).context("invalid IFLA_MIN_MTU value")?,
),
IFLA_MAX_MTU => Self::MaxMtu(
parse_u32(payload).context("invalid IFLA_MAX_MTU value")?,
Expand Down