feat: add netkit support #185
Open
+269
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathay4t
requested changes
Nov 19, 2025
Member
cathay4t
left a comment
cathay4t
left a comment
There was a problem hiding this comment.
Great work. Small changes required.
| } | ||
|
|
||
| const NETKIT_POLICY_PASS: u32 = 0; | ||
| const NETKIT_POLICY_DROP: u32 = 2; |
Member
There was a problem hiding this comment.
Please use kernel constant name for the seek of developer to search in linux kernel.
And also , you missed NETKIT_REDIRECT
NETKIT_PASS = 0,
NETKIT_DROP = 2,
NETKIT_REDIRECT = 7,|
|
||
| use super::super::{LinkMessage, LinkMessageBuffer}; | ||
|
|
||
| const NETKIT_MODE_L2: u32 = 0; |
Member
There was a problem hiding this comment.
Please use kernel constant name: NETKIT_L2
| const IFLA_NETKIT_PRIMARY: u16 = 2; | ||
| const IFLA_NETKIT_POLICY: u16 = 3; | ||
| const IFLA_NETKIT_PEER_POLICY: u16 = 4; | ||
| const IFLA_NETKIT_MODE: u16 = 5; |
Member
There was a problem hiding this comment.
Missing:
IFLA_NETKIT_SCRUB,
IFLA_NETKIT_PEER_SCRUB,
IFLA_NETKIT_HEADROOM,
IFLA_NETKIT_TAILROOM,It's OK to skip them for now.
| #[derive(Debug, PartialEq, Eq, Clone, Copy)] | ||
| #[non_exhaustive] | ||
| pub enum NetkitPolicy { | ||
| Pass, |
Member
There was a problem hiding this comment.
iproute is treating this as forward.
Maybe create alias for that.
impl NetkitPolicy {
pub const Forward = Self::Pass;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for netkit devices
https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/?id=22360fad5889cbefe1eca695b0cc0273ab280b56