Skip to content

database: downcast methods for NostrDatabase trait #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yukibtc
Copy link
Member

@yukibtc yukibtc commented Apr 23, 2025

No description provided.

yukibtc added a commit that referenced this pull request Apr 23, 2025
This allows downcasting `Arc<dyn NostrSigner` to `Keys` or other concrete signer types.

Pull-Request: #845
Signed-off-by: Yuki Kishimoto <[email protected]>
@yukibtc yukibtc force-pushed the downcasting branch 2 times, most recently from ef465f8 to 729eb91 Compare April 23, 2025 07:30
yukibtc added a commit that referenced this pull request Apr 23, 2025
This allows downcasting `Arc<dyn NostrSigner` to `Keys` or other concrete signer types.

Pull-Request: #845
Signed-off-by: Yuki Kishimoto <[email protected]>
yukibtc added a commit that referenced this pull request Apr 23, 2025
This allows downcasting `Arc<dyn NostrSigner` to concrete database types.

Pull-Request: #845
Signed-off-by: Yuki Kishimoto <[email protected]>
@yukibtc yukibtc added this to the Release v0.42 milestone Apr 23, 2025
@yukibtc yukibtc modified the milestones: Release v0.42, Release v0.43 May 12, 2025
yukibtc added a commit that referenced this pull request Jun 10, 2025
This allows downcasting `Arc<dyn NostrSigner>` to `Keys` or other concrete signer types.

Pull-Request: #845
Signed-off-by: Yuki Kishimoto <[email protected]>
yukibtc added a commit that referenced this pull request Jun 10, 2025
This allows downcasting `Arc<dyn NostrDatabase>` to concrete database types.

Pull-Request: #845
Signed-off-by: Yuki Kishimoto <[email protected]>
yukibtc added a commit that referenced this pull request Jun 10, 2025
Implement downcasting for `NostrDatabase`, allowing access to concrete database types.

Pull-Request: #845
Signed-off-by: Yuki Kishimoto <[email protected]>
yukibtc added a commit that referenced this pull request Jun 10, 2025
This allows downcasting `Arc<dyn NostrSigner>` to `Keys` or other concrete signer types.

Pull-Request: #845
Signed-off-by: Yuki Kishimoto <[email protected]>
yukibtc added a commit that referenced this pull request Jun 10, 2025
This allows downcasting `Arc<dyn NostrDatabase>` to concrete database types.

Pull-Request: #845
Signed-off-by: Yuki Kishimoto <[email protected]>
@yukibtc yukibtc changed the title Allow downcasting from traits to concrete types database: downcast methods for NostrDatabase trait Jun 10, 2025
yukibtc added a commit that referenced this pull request Jun 10, 2025
Implement downcasting methods to the `NostrDatabase` trait, allowing easy conversion to concrete database types.

Pull-Request: #845
Signed-off-by: Yuki Kishimoto <[email protected]>
Implement downcasting methods to the `NostrDatabase` trait, allowing easy conversion to concrete database types.

Pull-Request: #845
Signed-off-by: Yuki Kishimoto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant