Skip to content

convert NIP96 to I/O-free implementation #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

convert NIP96 to I/O-free implementation #935

wants to merge 3 commits into from

Conversation

frankomosh
Copy link
Contributor

@frankomosh frankomosh commented Jun 22, 2025 •
edited
Loading

Removed reqwest dependency from the core library of NIP96 and added I/O-free functions. Intention here being to allow users to have more choice on client to use

partially addresses #930

@frankomosh
refactor: convert NIP05, NIP11, NIP96 to I/O-free
a167eec 
Removed reqwest dependency from the core library and added I/O-free functions for all these three NIPs.

close rust-nostr#930
@frankomosh frankomosh marked this pull request as draft June 22, 2025 14:54
@frankomosh
Copy link
Contributor Author

frankomosh commented Jun 22, 2025 •
edited
Loading

Hello @yukibtc , please have a look at this . Changing nip11 causes issues in nostr-relay-pool/src/relay/inner.rs. If you find my approach right then we can maybe open another PR for nostr-relay-pool/src/relay/inner.rs?

@yukibtc
Copy link
Member

yukibtc commented Jun 23, 2025

Hey, thanks for the PR! I've started working on the NIP-05 module on Friday, but I didn't pushed the commits. I've opened now the PR: #936

Let me know what do you think. We can take the best of the 2 PRs.

@yukibtc
Copy link
Member

yukibtc commented Jun 23, 2025

Hello @yukibtc , please have a look at this . Changing nip11 causes issues in nostr-relay-pool/src/relay/inner.rs. If you find my approach right then we can maybe open another PR for nostr-relay-pool/src/relay/inner.rs?

I think we can open another PR for all the NIP11 changes (both in nostr and nostr-relay-pool crates). Also, I don't know what to do exactly with the NIP11 in the nostr-relay-pool. I guess it can be eventually completely removed, and the devs can get it "manually", with the library they prefer, if they need it?

@frankomosh
Copy link
Contributor Author

Hello @yukibtc , please have a look at this . Changing nip11 causes issues in nostr-relay-pool/src/relay/inner.rs. If you find my approach right then we can maybe open another PR for nostr-relay-pool/src/relay/inner.rs?

I think we can open another PR for all the NIP11 changes (both in nostr and nostr-relay-pool crates). Also, I don't know what to do exactly with the NIP11 in the nostr-relay-pool. I guess it can be eventually completely removed, and the devs can get it "manually", with the library they prefer, if they need it?

yeah I guess that would be nice.. we can create a seperate pr for nip11. Definately it has to change to remove all IO dependency in inner.rs.

@frankomosh
restore original NIP05 and NIP11 impls
c3bb7c4 
- NIP05 already handled by @yukibtc in separate PR
- NIP11 will be addressed in future PR
- Focus this PR solely on NIP96
@frankomosh frankomosh changed the title refactor: convert NIP05, NIP11, NIP96 to I/O-free convert NIP96 to I/O-free implementation Jun 24, 2025
@frankomosh
convert NIP96 to I/O-free impl
6c9c592 
- Remove reqwest dependency from NIP96
- Add I/O-free server config and file upload fns
- Update example to demonstrate new I/O-free API

Partially addresses rust-nostr#930 (NIP96 portion only)
@frankomosh frankomosh marked this pull request as ready for review June 24, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frankomosh @yukibtc