Implement checked arithmetic #152
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulXiCao
suggested changes
Oct 26, 2025
Comment on lines
+868
to
+891
| impl<T: Clone + Num + CheckedAdd + CheckedSub + CheckedMul + CheckedDiv> CheckedDiv for Complex<T> { | ||
| #[inline] | ||
| fn checked_div(&self, other: &Self) -> Option<Self> { | ||
| let norm_sqr = other | ||
| .re | ||
| .checked_mul(&other.re)? | ||
| .checked_add(&other.im.checked_mul(&other.im)?)?; | ||
|
|
||
| let re = self | ||
| .re | ||
| .checked_mul(&other.re)? | ||
| .checked_add(&self.im.checked_mul(&other.im)?)?; | ||
|
|
||
| let im = self | ||
| .im | ||
| .checked_mul(&other.re)? | ||
| .checked_sub(&self.re.checked_mul(&other.im)?)?; | ||
| Some(Self::new( | ||
| re.checked_div(&norm_sqr)?, | ||
| im.checked_div(&norm_sqr)?, | ||
| )) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
IMHO I find it far easier to read if one uses aliases for the real/imag parts as in the formula of the documentation block above, e.g.
let (a, b) = (&self.re, &self.im);
let (c, d) = (&other.re, &other.im);
let norm_sqr = c.checked_mul(c)?.checked_add(&d.checked_mul(d)?)?;
...Inconsistency to other code sections needs to be weighted in though...
There was a problem hiding this comment.
Nowhere else in the arithmetic code does this as far as I can tell.
| } | ||
|
|
||
| impl<T: Clone + Num + CheckedAdd + CheckedSub + CheckedMul + CheckedDiv + CheckedRem> Complex<T> { | ||
| fn checked_div_trunc(&self, divisor: &Self) -> Option<Self> { |
There was a problem hiding this comment.
Could be added to the mr description.
There was a problem hiding this comment.
It parallels the implementation for Rem, which has its own private method div_trunc which is right above it and right beside the Rem impl. I don't believe it's specifically noteworthy to merit being added to the PR description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
Checked[Add,Sub,Mul,Div,Rem]traits fromnum_traits.