add a round_ties_even for Ratio<T> #141
Open
+62
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i am working on a rust scheme interpreter, and the scheme
(round x)
procedure is specified to "round[...] to even when x is halfway between two integers", and is supposed to work on all number types available in scheme, which includes rationals.since that interpreter uses this library, so i figured i'd try to get my implementation into upstream.
the actual implementation i did seems "too easy", i just
cmp
it with aRatio::new(one, two)
and then do the same withGreater
andLess
like theround
fn does it. if it isEqual
i first round towards zero (viatrunc
, like in theLess
path) see if itis_even
, and then round away from zero (by adding/subtracting 1, like in theGreater
path) if not.