-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add an extra method to (Checked)Euclid trait to get both quotien and rem #291
feat: add an extra method to (Checked)Euclid trait to get both quotien and rem #291
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested some fixes for the documentation. I would also appreciate some tests, and doc-examples are an easy way to both demonstrate the feature and test it.
I think we should drop "with" from the name, just div_rem_euclid
and checked_div_rem_euclid
. This will be more similar to Integer::div_rem
.
@cuviper it's ready for another review |
@cuviper Ready for review |
Thanks! bors r+ |
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
closes #290