Add legacy-functions feature to wrapper and bindings
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cldfire
added
enhancement
backwards-compatibility
|
@KisaragiEffective bump, no worries if you're busy but would love to get your thoughts before merging this :) |
KisaragiEffective
approved these changes
Jan 5, 2023
There was a problem hiding this comment.
Hi, it's been a while (I've been on the edge in last month). This change looks good for me :) (compiles on both local and my CI -- KisaragiEffective/nikka-leaps#20)
Thank you for your efforts and applying my (initial) suggestion.
|
Nice, thanks for giving it a go! I'll get this out in a release when I have the opportunity. |
Unfortunately there is no way to compile but not run doctests in CI only
|
This has been released :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to enable a feature and then have access to older versions of functions in both the wrapper and the bindings.
Initially adding wrappers for the v2 versions of running compute / graphics processes.
Closes #33.