-
-
Notifications
You must be signed in to change notification settings - Fork 2
Let RngCore: TryRngCore<Error = Infallible>
#45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+225
−203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newpavlov
reviewed
Jan 12, 2026
Member
Author
|
Updated. Some things need further discussion (see above). |
newpavlov
reviewed
Jan 14, 2026
newpavlov
reviewed
Jan 14, 2026
RngCore: TryRngCoreRngCore: TryRngCore<Error = Infallible>
newpavlov
reviewed
Jan 14, 2026
newpavlov
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdentrySummary
Revise the core traits according to @newpavlov's suggestion and similar to #41 but keeping the infallible methods.
No trait renames are done in this PR. Also not sure if we need any.
Details
TryRngCoreis implemented for anyR: DerefMutwhereTarget: TryRngCore.RngCore: TryRngCore<Error = Infallible>with automatic implementation overTryRngCoreUnwrapMutis removedCryptoRng = RngCore + TryCryptoRngor as close as possible without sum traits; it is kept since I believe some people needdyn CryptoRngutils::{next_u64_via_u32, next_word_via_fill}now use closures instead ofR: RngCoreQuestions
Should
utilsfns support potentially-fallible uses (try_next_u64_via_u32takesFnMut() -> Result<u32; E>for genericE)? I think unnecessary.