Skip to content

Conversation

@nadzyah
Copy link
Member

@nadzyah nadzyah commented Jul 20, 2025

The change contains basic implementation of the command with unittests.

Currently, for simplicity, the tail command itself doesn't accept any options, i.e. running it as tailor -f <filename> <command> is not possible. However, the alternative command accepts as many options as needed, and the filename is passed as the last option there.

@nadzyah nadzyah requested a review from bdrung July 20, 2025 21:05
Copy link
Member

@bdrung bdrung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Instead of can_tail_file we could tail the file ourselves instead calling tail, but that is a task for a future PR.

Copy link
Member

@lvoytek lvoytek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just found a typo in the long_about

@nadzyah
Copy link
Member Author

nadzyah commented Jul 21, 2025

LGTM. Instead of can_tail_file we could tail the file ourselves instead calling tail, but that is a task for a future PR.

do you also mean to implement all the supported tail options ourselves?

nadzyah added 2 commits July 21, 2025 20:53
The change contains basic command implementation with unittests
@nadzyah
Copy link
Member Author

nadzyah commented Jul 21, 2025

@bdrung @lvoytek let me know if you're fine with the changes and feel free to merge

@lvoytek
Copy link
Member

lvoytek commented Jul 22, 2025

LGTM!

@nadzyah nadzyah merged commit 6c69c73 into main Jul 22, 2025
1 check passed
@nadzyah nadzyah deleted the init-project branch July 22, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants