Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add BITS associated constant #69

Merged
merged 2 commits into from
Mar 1, 2024
Merged

add BITS associated constant #69

merged 2 commits into from
Mar 1, 2024

Conversation

bbaldino
Copy link
Collaborator

closes #55

chrysn
chrysn reviewed Mar 1, 2024
View reviewed changes
Copy link
Member

@chrysn chrysn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BITS of the builtins are all u32 and not usize. Any reason for that? (Either is large enough on all platforms, so I'd guess that consistency would win, which would come from using u32)

@bbaldino
Copy link
Collaborator Author

bbaldino commented Mar 1, 2024

🤦 I swear I checked that first and thought it was usize. Will fix this.

chrysn
chrysn approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@chrysn chrysn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's merge this.

@chrysn chrysn merged commit bd22f23 into rust-ux:master Mar 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrysn chrysn chrysn approved these changes

Assignees

@chrysn chrysn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding BITS constants to match inbox primitive types.
2 participants
@bbaldino @chrysn