Skip to content

Introduce Mutex<T: DeviceIoMut> adapter for DeviceIo #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Introduce Mutex<T: DeviceIoMut> adapter for DeviceIo #20

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2f4c51c
Introduce Mutex<T: DeviceIoMut> adapter for DeviceIo
jiangliu Feb 1, 2020
5bd69ad
Make DeviceIo depend on Sync
jiangliu Feb 1, 2020
1d55fc8
Implement Clone for IoManager
jiangliu Feb 1, 2020
3fc25ea
Export IoSize and IoRange as pub
jiangliu Feb 7, 2020
bdf834e
Implement Deref for DeviceResources
jiangliu Jan 24, 2020
11f77fb
resource: derive Debug for resource related structs
jiangliu Feb 4, 2020
2d9c7e6
Build dedicated structs/interfaces for Pio
jiangliu Feb 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ impl PartialOrd for IoAddress {
/// real concurrent multiple threads handling. For device backend drivers not
/// focusing on high performance, they may use the Mutex<T: DeviceIoMut>
/// adapter to simplify implementation.
pub trait DeviceIo: Send {
pub trait DeviceIo: Send + Sync {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense for this to be Sync, but (just wondering, like the previous question) does anything depend on it being Send as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The the DeviceIo needs to be Send + Sync for Arc to be Sync:)

/// Read from the guest physical address `base`, starting at `offset`.
/// Result is placed in `data`.
fn read(&self, base: IoAddress, offset: IoAddress, data: &mut [u8]);
Expand Down