Deprecate UiKitWindowHandle::ui_view_controller
#175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
force-pushed
the
deprecate-ui-view-controller
branch
2 times, most recently
from
c7243c6 to
af9ae13
Compare
This can be retrieved from the UIView itself, and is hence unnecessary information for us to carry around. Besides, since it's optional, users that want to get the view controller has to do the searching logic anyways.
madsmtm
force-pushed
the
deprecate-ui-view-controller
branch
from
af9ae13 to
abfe839
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be retrieved from the
UIViewitself, and is hence unnecessary information for us to carry around.Besides, since it's optional, users that want to get the view controller has to do the searching logic anyways.
Once we remove this in the next breaking version, we should move the example code I've provided on
ui_view_controllerhere to an example instead.