-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add safe area and document coordinate systems #3890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 38 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
98a9914
Add safe area and document coordinate systems
madsmtm 335a1c6
Attempt to show better show that positions are relative to something
madsmtm 3cd2fa6
Remove extra comment that was more confusing than helpful
madsmtm 9bcd3ff
Improve docs, allow safe area to include transparent title bar
madsmtm bec2ed1
Use possibly negative values for surface position
madsmtm 81c92eb
Fix safe_area on macOS < 11
madsmtm d5d8e30
Fix outer_size on iOS
madsmtm b1fee88
Remove draw.io files from typos check
madsmtm 5df9eb8
Fix doc link
madsmtm da7942e
Fix SurfaceResized on iOS
madsmtm 9f080a5
Always redraw when the safe area changes
madsmtm bc12e13
Properly set up typos check
madsmtm 287fd8d
Add Android, Orbital, Web, Windows, Wayland and X11 implementations
madsmtm ba76cc6
Fix Android inner_position/surface_position name
madsmtm 8561d3b
Fix clippy warning on Windows
madsmtm feb686a
Fix size of desktop coordinate systems image
madsmtm e878c59
Note on android that there's events for safe area insets
madsmtm c7523d4
Add docs on also emitting RedrawRequested when safe area changes
madsmtm 01552d5
Move docs on safe area to # Drawing on the window
madsmtm 45326fb
Remove comment about CSD in safe_area on wayland
madsmtm c651490
Remove fixmes, use issue to track instead
madsmtm c1ea82a
Change note on negative surface position
madsmtm 39f40c7
Make safe area position vs. size a bit clearer
madsmtm 131eaa1
Add dot and arrow to the start and end of position indicators
madsmtm 62a95a5
macOS: Guarantee that SurfaceResized is emitted on safe area change
madsmtm 3b3928e
Don't mention Alacritty
madsmtm 992778a
Comment before mobile picture
madsmtm 1ffa29b
Implement Web
daxpedda 025bb67
Improve rustfmt note
madsmtm 2caf761
doc function
madsmtm 9a4c51c
Document that safe area != occlusion
madsmtm 51269ce
Add inset types
madsmtm 12f3666
Use insets instead of rectangle
madsmtm 00fe76e
Merge remote-tracking branch '0origin/master' into madsmtm/safe-area
madsmtm c288aeb
Fix web
madsmtm 566b790
Remove test code
madsmtm 8143515
Update mobile diagram
madsmtm 773b002
Fix broken doc
madsmtm 20c95c2
Draw a rectangle instead of a star
madsmtm 70398a1
Merge branch 'master' into madsmtm/safe-area
madsmtm bea232c
Fix text on devices with a larger monospace font
madsmtm 1594cea
Move source files out of docs/res, into docs
madsmtm 20fc250
Merge branch 'master' into madsmtm/safe-area
madsmtm 5cf650a
Fix missing newline
madsmtm de2414f
Update outdated comment
madsmtm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchibisov marked this conversation as resolved.
Show resolved
Hide resolved
|
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.