Skip to content

Conversation

@madsmtm
Copy link
Member

@madsmtm madsmtm commented Dec 2, 2024

Similar to #4027, I didn't test the implementation of safe_area properly on older devices when I made it in #3890, likely after migrating that from rectangles to insets.

  • Tested on all platforms changed
    • Tested on macOS 14.7.1 and macOS 10.12.6
  • Added an entry to the changelog module if knowledge of this change could be valuable to users
    • This is going to go in the same release as the PR the bug was introduced in, so have not added a changelog entry.
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality

@madsmtm madsmtm added B - bug Dang, that shouldn't have happened DS - appkit Affects the AppKit/macOS backend labels Dec 2, 2024
@madsmtm madsmtm added this to the Version 0.31.0 milestone Dec 2, 2024
@madsmtm madsmtm merged commit 132fbe1 into master Dec 3, 2024
58 checks passed
@madsmtm madsmtm deleted the madsmtm/macos-safe-area-old branch December 3, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B - bug Dang, that shouldn't have happened DS - appkit Affects the AppKit/macOS backend

Development

Successfully merging this pull request may close these issues.

3 participants