Skip to content

Conversation

@tymmesyde
Copy link

@tymmesyde tymmesyde commented Jun 4, 2025

Add support for DroppedFile, HoveredFileCancelled and HoveredFile window events that were not supported on Wayland.

  • Tested on all platforms changed
  • Added an entry to the changelog module if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality

@tymmesyde tymmesyde requested a review from kchibisov as a code owner June 4, 2025 17:56
@tymmesyde tymmesyde changed the title feat(wayland): add support for file window events Add support for file window events on Wayland Jun 4, 2025
@HookedBehemoth
Copy link

Is this still a draft PR?
I think this should merge into master, instead of the last tagged release.
Over there you can also push the x, y positions into the events.

I've tried this commit but leave doesn't seem to work.

@tymmesyde
Copy link
Author

Is this still a draft PR? I think this should merge into master, instead of the last tagged release. Over there you can also push the x, y positions into the events.

I've tried this commit but leave doesn't seem to work.

It's not a draft PR, waiting for feedback on the code and if there are bugs to fix
Thank you, yes the HoveredFileCancelled event was not dispatched, it should be fixed now

@kchibisov
Copy link
Member

There're plenty of PRs dealing with it already, and have everything in place to figure out the design.

@madsmtm madsmtm added the DS - wayland Affects the Wayland backend, or generally free Unix platforms label Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DS - wayland Affects the Wayland backend, or generally free Unix platforms

Development

Successfully merging this pull request may close these issues.

4 participants