Add some missing Window getters #4348
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented properly when it was easy for me, but a lot of places are stubbed out for now.
madsmtm
requested review from
daxpedda,
jackpot51 and
kchibisov
as code owners
daxpedda
approved these changes
Sep 5, 2025
| /// ## Platform-specific | ||
| /// | ||
| /// - **iOS / Android / Orbital:** Unsupported. | ||
| /// - **Web:** Unimplemented, returns `None`. |
There was a problem hiding this comment.
Suggested change
| /// - **Web:** Unimplemented, returns `None`. | |
| /// - **Web:** Unimplemented. |
I propose if it returns Option, we don't have to specify that it returns None.
| /// | ||
| /// - **iOS / Android:** Unsupported. | ||
| fn set_title(&self, title: &str); | ||
| /// - **iOS / Android / Web:** Unsupported. |
There was a problem hiding this comment.
Suggested change
| /// - **iOS / Android / Web:** Unsupported. | |
| /// - **iOS / Android / Web:** Unsupported. Always returns `false`. |
I propose if it returns a bool, we should specify what it returns in case its unsupported or unimplemented.
| /// - **iOS / Android:** Unsupported. | ||
| fn set_title(&self, title: &str); | ||
| /// - **iOS / Android / Web:** Unsupported. | ||
| /// - **X11:** Unimplemented, returns `false`. |
There was a problem hiding this comment.
Suggested change
| /// - **X11:** Unimplemented, returns `false`. | |
| /// - **X11:** Unimplemented. Returns `false`. |
I propose we use two sentences. Was told before by people who know better that in English you don't use commas a whole lot, but what do I know.
| /// | ||
| /// ## Note | ||
| /// | ||
| /// - You shouldn't stop rendering for minimized windows, however you could lower the fps. |
There was a problem hiding this comment.
Suggested change
| /// - You shouldn't stop rendering for minimized windows, however you could lower the fps. | |
| /// - To support window previews you should continue rendering minimized windows. However, you could lower the frame rate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following methods to
Window:min_surface_size.max_surface_size.is_transparent.is_blurred.window_level.window_icon.content_protected.cursor.Some of these are not implemented on all platforms yet, I have marked that in their documentation. I it to be a general theme of
Window, you should be able to query all the properties that you can set.Related to #1295 and #3690.
changelogmodule if knowledge of this change could be valuable to users