winit-appkit: commit even if marked text is nothing. #4396
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Most Sogou-style pinyin IME were designed to not use marked text feature when directly committing punctuations. That's why this patch is necessary, allowing them to input punctuations correctly without committing the character hardcoded in the base ukelele keylayout used by the input method.
4 tasks
|
Closing. Reason: An unintentional duplication of #4374 . |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most Sogou-style pinyin IME were designed to not use marked text feature when directly committing punctuations. That's why this patch is necessary, allowing them to input punctuations correctly without committing the character hardcoded in the base ukelele keylayout used by the input method.
Tested on all platforms changed // I need to test this in Alacritty, but I'm not familiar with Cargo. I need someone else to help me compile a copy of Alacritty so I can do the test.
Added an entry to the
changelogmodule if knowledge of this change could be valuable to usersUpdated documentation to reflect any user-facing changes, including notes of platform-specific behavior
Created or updated an example program if it would help users understand this functionality