Fix: CLI flag inconsistency in hive-mind command (Alpha 52) - #257
Merged
Conversation
- Create .claude/mcp.json with MCP server configurations during init - Update manual setup instructions to use correct npx commands - Add note about copying mcp.json as an alternative setup method Related to #251
- Add gitignore-updater.js module to manage .gitignore entries - Automatically add Claude Flow generated files to .gitignore - Use --force flag to update existing .gitignore entries - Update help documentation to mention .gitignore handling Implements #255
This was referenced Jul 14, 2025
- Add new command to fix ${file} and ${command} variable interpolation
- Automatically transforms legacy syntax to working environment variables
- Creates backups before modifying settings files
- Supports multiple syntaxes (environment vars, wrapper scripts)
- Includes comprehensive test harness and documentation
- Transforms ${file} → $CLAUDE_EDITED_FILE, ${command} → $CLAUDE_COMMAND
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Add section about fixing hook variable interpolation
- Document transformation from ${file} to $CLAUDE_EDITED_FILE
- Include examples and usage instructions
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
|
See comments in closed issue |
- Add official jq JSON parsing approach based on Claude Code docs - Update command to support --syntax jq option - Create comprehensive test scripts for all approaches - Add test configurations to help users verify which syntax works - Update documentation to reflect uncertainty about env vars The jq approach is based on official Claude Code documentation and is likely more reliable than the undocumented environment variable approach. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Set JQ parsing as default based on official docs and testing - Confirmed JQ syntax works with Claude Code hooks - Update test hook creation to use JQ syntax - Add validation test configurations The JQ approach is more reliable as it's officially documented and proven to work, unlike the undocumented environment variables. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Updated init command templates to use JQ syntax instead of legacy ${file}
- Fixed settings.json template with proper PreToolUse/PostToolUse format
- Ensured both static template and fallback function use consistent JQ parsing
- Hook variables now work reliably: .tool_input.file_path // .tool_input.path
- New projects automatically get working hook variables via init command
- Resolves variable interpolation issue #249
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
Owner
Author
|
Thank you for this comprehensive PR that fixes multiple CLI issues! I've reviewed the changes and they look good: ✅ Changes Reviewed:1. CLI Flag Consistency Fix (#252)
2. MCP Configuration (#251)
3. Hook Variable Interpolation (#249)
4. .gitignore Updates (#255)
🔴 CI Status:The PR currently has failing CI checks. It appears to be related to test failures across multiple environments. Before merging, we should:
Would you like me to help investigate the specific test failures? Once the CI is green, this PR will be ready to merge! |
Owner
Author
📝 Update: CI StatusI've checked the main branch and it also has failing CI checks, so these failures appear to be pre-existing issues not caused by this PR. Since:
I'm proceeding with the merge. We can address the CI issues in a separate PR focused on fixing the test suite. Merging now... 🚀 |
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
CLI Flag Fixes (#252)
--memory-sizeandmemorySizeformatsMCP Configuration (#251)
initcommandHook Variable Interpolation Fix (#249)
fix-hook-variablescommand to fix${file}syntax issues.gitignore Updates (#255)
Test Plan
Issues Fixed
🤖 Generated with Claude Code