-
Notifications
You must be signed in to change notification settings - Fork 16
Partial enabling of transition types for different label scorers #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SimBe195
wants to merge
22
commits into
master
Choose a base branch
from
disabled-transition-types
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curufinwe
requested changes
Oct 9, 2025
curufinwe
approved these changes
Oct 10, 2025
hannah220
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a parameterto the LabelScorer base class which allows users to specify a list of transition types which will always get assigned score 0 and not affect the ScoringContext. This can be especially helpful when building combined label scorers with multiple sub-scorers of different label topology such as for example CTC + LSTM LM where the LM needs to ignore all blank transitions as well as label loops and CTC on the other hand needs to ignore the sentence-end.ignored-transition-types
Do achieve this,
extendedScoringContext
,computeScoreWithTime
andcomputeScoresWithTimes
are implemented in the baseLabelScorer
and call protected functions{extendedScoringContext|computeScoreWithTime|computeScoresWithTimes}Internal
which are overridden in child classes.Depends on modifications to the transition type handling from #138.
Edit:
This logic was changed so that instead of a blacklist, the LabelScorer has a parameter
transition-preset
which enables a preconfigured list of used transition types for specific models and any additional ones can be enabled via another parameterextra-transition-types
. The available presets for now are"default"
,"none"
,"ctc"
,"transducer"
and"lm"
. When thedefault
preset is used, it takes a preset that is specified by each LabelScorer subclass individually and should be the most common use-case for that class. For example forCombineLabelScorer
the default will use preset "all", forNoContextOnnxLabelScorer
the default will use preset "ctc" and so on.