-
Notifications
You must be signed in to change notification settings - Fork 132
Add tensorboard to torch engine #1704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
robin-p-schmitt
wants to merge
39
commits into
master
Choose a base branch
from
robin-tensorboard
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
e1618e5
add tensorboard to torch engine
robin-p-schmitt 8950739
cleanup
robin-p-schmitt ce3d1d8
cleanup
robin-p-schmitt 394f35c
update
robin-p-schmitt 4f82abd
update
robin-p-schmitt a2d4234
CI fix transformers version, fix #1706
albertz 03a7526
CI fix transformers version on older Python
albertz 36abfc6
Vocabulary, parse utf8
albertz a11ee1a
Vocabulary, better error exception on duplicates
albertz 34e3448
LibriSpeechCorpus, orth_post_process, small fix type
albertz b95b743
LmDataset, support orth_post_process
albertz f6e07d8
Vocabulary, line-based vocab, use as-is, even with duplicates
albertz 7a1d54e
Vocabulary, small fix warning, cleanup
albertz cd1cbcc
PT preload_from_files without filename, allow prefix
albertz 048bc87
Torch, fix _print_process handling of undef complete_frac (#1711)
dorian-K 027061f
PostprocessingDataset, implement get_all_tags
albertz e568db2
SimpleHDFWriter, sanity checks (#1713)
albertz 9dd16e3
RF RunCtx train_flag per func (#1714)
albertz 6e0542a
DummyDataset, fix dtypes
albertz 31f4423
PostprocessingDataset, fix pickling
albertz dc3667a
is_running_on_cluster: also check SLURM_JOB_ID
albertz a9b12e7
cf: catch also OSError
albertz 2c99a76
MetaDataset, better err msg
albertz b72475a
VariableDataset, always_same_tags option, support get_all_tags
albertz aa9f932
dump-dataset, faster and more generic serialization
albertz 622e4ef
FileCache: hold lock and refresh mtime during cleanup (#1709)
NeoLegends 3a84cb1
Torch engine, epoch_start, epoch_end func for training/eval
albertz 850a2ee
`DistributeFilesDataset`: allow specifying files via list file (#1717)
NeoLegends 6779deb
SentencePieces, handle sis Path
albertz 8588507
Torch, handle available_for_inference in extern_data
albertz 2860715
Make SimpleHDFWriter a context manager
NeoLegends 352af14
SimpleHDFWriter: small comment fix
NeoLegends 639f800
RF scatter_mean
albertz 8cd49a1
update better_exchook
albertz f157fa9
get_complete_frac fix when num_seqs is None (#1722)
albertz 1112cab
tooling: change formatter to ruff (#1719)
NeoLegends 1a5d0db
update
robin-p-schmitt a77e5f4
update
robin-p-schmitt 5110779
Merge branch 'master' into robin-tensorboard
robin-p-schmitt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder whether we should use
self.global_train_step
here instead.We did it like that for TF. Also to have it comparable to the train scores. But I was also not so sure about that.
Other opinions? @NeoLegends? @Atticus1806? @JackTemaki? @vieting? @michelwi?