Frame jumping breaks instanceOf#166
Merged
Merged
Conversation
itmaybejj
commented
Jun 13, 2026
| if (State.option.fixedRoots) { | ||
| root.push(State.option.fixedRoots); | ||
| // fixedRoots are an array of objects with a fixedRoot and a positioner. | ||
| root.push(State.option.fixedRoots.map((entry) => entry?.fixedRoot).filter(Boolean)); |
Contributor
Author
There was a problem hiding this comment.
This is a breaking change if anybody else is using fixedRoots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is specific to live editing using fixedRoots across iframes: anything that checks against
instanceOfreturnsfalsebecause the inner DOM nodes are not instances of anything in the wrapper page.OMG debugging this stumped both me and Opus for hours. Stuff would just randomly not get detected in the iframe, even with identical DOM.