Added MySQL Database Support (updated pyproject dependencies) by CodeStrate · Pull Request #7 · s-bose/wandern

CodeStrate · 2025-10-21T18:03:11Z

Added mysql connector dependency and updated README and pyproject to reflect it (similar to postgresql)
Added utility to parse individual connection params from DSN for MySQL
Migration Logic borrowed from SQLite with MySQL syntax specific changes

s-bose

Documentations missing.
Several issues with code structure and refactor
Unit tests missing.

Overall nice work! Please fix the highlighted bits and add comprehensive unit tests.

wandern/databases/mysql.py

wandern/models.py

CodeStrate · 2025-10-22T03:33:43Z

Could you elaborate on the documentation part?

s-bose · 2025-10-22T07:59:17Z

Could you elaborate on the documentation part?

I mean in the readme there should be a mention of mysql and the dsn format.

- Removed unnecessary comments. - Added a MySQLConnectionParams typedDict in place of typing.Dict - Reworked generic exceptions to be more specific. and removed unnecessary exceptions. - Removed defaults in params and structured query string params better.

- Changed TEXT to VARCHAR with fixed length as per MySQL syntax. - Fixed a typo in providers to implement MySQLProvider correctly. - Fixed Unread result errors while testing by correctly consuming cursor results.

CodeStrate · 2025-10-24T16:44:23Z

@s-bose Added unit tests using the existing implementations as base.
30 tests passed and 1 failed due assertion on autocommit
Changed the documentation and added the structural changes as requested. Could you review?

CodeStrate · 2025-10-24T16:59:35Z

I need your assistance since unit testing is not my strong suit, any suggestions on the autocommit test might help.

EDIT: I saw postgres's autocommit true in connect, so followed that.

…syntax and added autocommit True to match Postgres.

CodeStrate

All requested changes are made @s-bose . Please review

pyproject.toml

wandern/databases/mysql.py

s-bose · 2025-10-27T17:44:45Z

@CodeStrate Just a few more nitpicky reviews. Please review and lmk. Otherwise LGTM for merge.

- Also removed self.connection_params making it a local variable.

CodeStrate · 2025-10-29T17:01:12Z

@s-bose Commit 12acbc6 fixes the two nitpicks you had. Please review and LMK if looks good to merge.

s-bose · 2025-10-30T13:55:28Z

Test CI is failing. Could you check please?

CodeStrate · 2025-10-30T13:57:39Z

I didn't add uv lock file to the repository so probably that's the reason

CodeStrate · 2025-10-30T17:08:58Z

@s-bose can you test the CI now?

s-bose · 2025-10-30T17:11:41Z

@CodeStrate There is a failing test.

https://github.com/s-bose/wandern/actions/runs/18948964620/job/54108342466

…ported testcase to avoid failure.

CodeStrate · 2025-10-30T17:24:48Z

@s-bose try 73a6da7. it was failing due to the unsupported testcase using mysql as a reference.

codecov-commenter · 2025-10-31T15:03:44Z

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

s-bose · 2025-10-31T20:38:05Z

@CodeStrate Two more things.

wandern/databases/mysql.py#L29-L90

Complex Method

Could you please try to shorten the code a bit?
And, could you please bump the package version to the next minor release?

Sorry for being a pain! :)

- Bumped Package version to 0.0.4 - Simplified the parser function in mysql.py and modified the tests accordingly.

CodeStrate · 2025-11-01T06:07:05Z

@s-bose with 095431a CodeFactor doesn't report an error now. I simplified the parser code, changed the 2 tests for missing host and port (combined them into one since we checked for either in the parser as both are required, and we don't assume any default fallbacks)

also bumped 0.0.3 to 0.0.4 :)

s-bose · 2025-11-01T16:14:54Z

@CodeStrate Merged!

Added MySQL Database Support (updated pyproject dependencies)

86dff09

CodeStrate mentioned this pull request Oct 21, 2025

Add support for MySQL dialect #4

Closed

s-bose requested changes Oct 21, 2025

View reviewed changes

CodeStrate added 4 commits October 24, 2025 16:08

Updated Docs to mention MySQL specific DSN workaround.

4a7c60c

Changes:

b19da6b

- Removed unnecessary comments. - Added a MySQLConnectionParams typedDict in place of typing.Dict - Reworked generic exceptions to be more specific. and removed unnecessary exceptions. - Removed defaults in params and structured query string params better.

Added Unit tests for MySQL using SQLite and Postgres as a base.

59fb6ba

Changes:

54274c4

- Changed TEXT to VARCHAR with fixed length as per MySQL syntax. - Fixed a typo in providers to implement MySQLProvider correctly. - Fixed Unread result errors while testing by correctly consuming cursor results.

Removed bare try-except blocks, changed timestamp according to MySQL …

3c13025

…syntax and added autocommit True to match Postgres.

CodeStrate commented Oct 26, 2025

View reviewed changes

s-bose requested changes Oct 27, 2025

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

wandern/databases/mysql.py Outdated Show resolved Hide resolved

Removed mysql libraries from direct dependencies.

12acbc6

- Also removed self.connection_params making it a local variable.

Added uv lock file.

86c313e

Added mysql test in test_provider and changed mysql to mssql in unsup…

73a6da7

…ported testcase to avoid failure.

s-bose self-assigned this Oct 31, 2025

s-bose self-requested a review October 31, 2025 15:08

s-bose approved these changes Oct 31, 2025

View reviewed changes

Changes:

095431a

- Bumped Package version to 0.0.4 - Simplified the parser function in mysql.py and modified the tests accordingly.

s-bose merged commit cd1c84c into s-bose:master Nov 1, 2025
3 checks passed

Conversation

CodeStrate commented Oct 21, 2025

Uh oh!

s-bose left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CodeStrate commented Oct 22, 2025

Uh oh!

s-bose commented Oct 22, 2025

Uh oh!

CodeStrate commented Oct 24, 2025

Uh oh!

CodeStrate commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CodeStrate left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

s-bose commented Oct 27, 2025

Uh oh!

CodeStrate commented Oct 29, 2025

Uh oh!

s-bose commented Oct 30, 2025

Uh oh!

CodeStrate commented Oct 30, 2025

Uh oh!

CodeStrate commented Oct 30, 2025

Uh oh!

s-bose commented Oct 30, 2025

Uh oh!

CodeStrate commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Oct 31, 2025

Welcome to Codecov 🎉

Uh oh!

s-bose commented Oct 31, 2025

Uh oh!

CodeStrate commented Nov 1, 2025

Uh oh!

Uh oh!

s-bose commented Nov 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CodeStrate commented Oct 24, 2025 •

edited

Loading

CodeStrate commented Oct 30, 2025 •

edited

Loading