fix: correct metadata previousDirectory in set_current_directory tool#81
Merged
fix: correct metadata previousDirectory in set_current_directory tool#81
Conversation
- Fixed bug where previousDirectory metadata was set to requested path instead of the actual previous working directory - Added comprehensive test coverage (20 tests) for set_current_directory including path validation, normalization, state management, and metadata - Tests cover edge cases: chdir failures, empty allowedPaths, restrictWorkingDirectory=false, Git Bash/WSL paths, and more Co-Authored-By: Claude Opus 4.6 <[email protected]>
- Fixed set_current_directory metadata bug (previousDirectory now returns actual previous directory) - Added comprehensive test coverage (20 tests) - Updated changelog with version 1.2.3 entry Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
previousDirectorymetadata was set to the requested path instead of the actual previous working directoryset_current_directorytoolBug Fix
Before: The
previousDirectoryfield in the response metadata was incorrectly set toargs.path(the requested path).After: The
previousDirectorynow correctly containsserverActiveCwd(the actual previous directory before the change).Test Coverage
Added 20 comprehensive tests covering:
restrictWorkingDirectory = falsescenariosallowedPathsscenariosprocess.chdir()failure handling (state consistency, permission denied)Test Results
All 796 tests pass (806 total, 10 skipped)
🤖 Generated with Claude Code