Reversed the order of the inner loop in removeFullyOverlappingStrings()

s9e · Dec 22, 2016 · da4a069 · da4a069
1 parent 524a345
commit da4a069
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/ShortestCommonSuperstring.php b/src/ShortestCommonSuperstring.php
@@ -195,10 +195,13 @@ protected function removeFullyOverlappingStrings()
 		{
 			$str = $this->strings[$i];
 			$len = $strlen[$i];
-			$j   = $i;
-			while (--$j >= 0)
+
+			// Iterate over strings starting with the longest. Stop when we reach strings the size
+			// of the current string
+			$j = -1;
+			while ($strlen[++$j] > $len)
 			{
-				if ($strlen[$j] > $len && strpos($this->strings[$j], $str) !== false)
+				if (strpos($this->strings[$j], $str) !== false)
 				{
 					unset($this->strings[$i]);
 					break;