Improved removeFullyOverlappingStrings() performance by adding a leng…

…th check
s9e · Dec 22, 2016 · f3e57ac · f3e57ac
1 parent dae48da
commit f3e57ac
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/ShortestCommonSuperstring.php b/src/ShortestCommonSuperstring.php
@@ -189,14 +189,16 @@ protected function removeEmptyStrings()
 	*/
 	protected function removeFullyOverlappingStrings()
 	{
-		$i = count($this->strings);
+		$strlen = array_map('strlen', $this->strings);
+		$i      = count($this->strings);
 		while (--$i > 0)
 		{
 			$str = $this->strings[$i];
-			$j = $i;
+			$len = $strlen[$i];
+			$j   = $i;
 			while (--$j >= 0)
 			{
-				if (strpos($this->strings[$j], $str) !== false)
+				if ($strlen[$j] > $len && strpos($this->strings[$j], $str) !== false)
 				{
 					unset($this->strings[$i]);
 					break;