Repository navigation
feat: add data-grid-keyboard-shortcuts registry - #1015
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extracts the DataGridKeyboardShortcuts component into a separate registry entry, allowing users to optionally include it in their data grid implementation rather than having it bundled by default.
Key Changes:
- Removed
DataGridKeyboardShortcutsfrom the core data-grid component - Created a new separate registry entry for the keyboard shortcuts component
- Updated the demo to show the component as an optional add-on
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/data-grid/data-grid.tsx | Removed the keyboard shortcuts component import and usage from the core DataGrid |
| src/components/data-grid/data-grid-demo.tsx | Added keyboard shortcuts component to demonstrate its optional usage |
| registry.json | Removed keyboard shortcuts from data-grid dependencies and created new standalone entry |
| public/r/registry.json | Mirror of registry.json changes for the public registry |
| public/r/data-grid.json | Removed keyboard shortcuts component from bundled data-grid files |
| public/r/data-grid-keyboard-shortcuts.json | New registry file defining the standalone keyboard shortcuts component |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
noodleman1991
pushed a commit
to noodleman1991/tablecn
that referenced
this pull request
Mar 12, 2026
anhdd-kuro
pushed a commit
to anhdd-kuro/tablecn
that referenced
this pull request
Apr 8, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.