Skip to content

fix(data-grid): prevent fetch rejection during prerendering #1074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sadmann7 merged 6 commits into from
Dec 18, 2025
Merged

fix(data-grid): prevent fetch rejection during prerendering #1074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a1bfd8e
fix: avoid fetch during prerender in data-grid-live page
sadmann7 Dec 18, 2025
c119b23
fix: move collection preload to client component to avoid prerender f…
sadmann7 Dec 18, 2025
b9ea325
fix: use dynamic import with ssr:false to prevent prerender fetch rej…
sadmann7 Dec 18, 2025
732e742
fix: add 'use client' directive for dynamic import with ssr:false
sadmann7 Dec 18, 2025
b1b1ec6
refactor: skeeleton layout
sadmann7 Dec 18, 2025
0768d4f
refactor: skeeleton size
sadmann7 Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/app/data-grid-live/components/data-grid-live-demo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { useLiveQuery } from "@tanstack/react-db";
import type { ColumnDef, SortingState } from "@tanstack/react-table";
import { CheckCircle2, Palette, Trash2, X } from "lucide-react";
import * as React from "react";
import { use } from "react";
import { toast } from "sonner";
import { skatersCollection } from "@/app/data-grid-live/lib/collections";
import {
Expand Down Expand Up @@ -82,6 +83,8 @@ const trickSelectOptions = trickOptions.map((trick) => ({
}));

export function DataGridLiveDemo() {
use(skatersCollection.preload());

const windowSize = useWindowSize();
const [sorting, setSorting] = React.useState<SortingState>([
{ id: "createdAt", desc: false },
Expand Down
18 changes: 8 additions & 10 deletions src/app/data-grid-live/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
"use client";

import dynamic from "next/dynamic";
import { use } from "react";
import { skatersCollection } from "@/app/data-grid-live/lib/collections";
import { Skeleton } from "@/components/ui/skeleton";

// Dynamic import to prevent SSR issues with useLiveQuery
// Dynamic import with ssr: false is required because:
// 1. useLiveQuery uses useSyncExternalStore which needs getServerSnapshot for SSR
// 2. Collection preload triggers fetch() which rejects during prerendering
const DataGridLiveDemo = dynamic(
() =>
import("./components/data-grid-live-demo").then(
Expand All @@ -16,19 +16,17 @@ const DataGridLiveDemo = dynamic(
loading: () => (
<div className="container flex h-[calc(100dvh-5.5rem)] flex-col gap-4 py-4">
<div className="flex items-center gap-2 self-end">
<Skeleton className="h-7 w-18" />
<Skeleton className="h-7 w-18" />
<Skeleton className="h-7 w-18" />
<Skeleton className="h-7 w-20" />
<Skeleton className="h-7 w-20" />
<Skeleton className="h-7 w-20" />
<Skeleton className="hidden h-7 w-20 lg:block" />
Comment thread
sadmann7 marked this conversation as resolved.
</div>
<Skeleton className="h-full w-full" />
<Skeleton className="size-full" />
</div>
),
},
);

export default function DataGridLivePage() {
// Preload the collection before rendering
use(skatersCollection.preload());

return <DataGridLiveDemo />;
}