Repository navigation
feat(data-grid): add nullable cells - #1135
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the “skaters” data-grid demo stack (DB schema → validation → UI/demo flows) to allow nullable values for select/number-like fields, so newly inserted rows can start with empty cells.
Changes:
- Made
stance,style,status, andyearsSkatingnullable at the Drizzle schema + Zod validation layers. - Updated live + multiplayer demo row creation to insert new skaters with
nullvalues for those fields. - Adjusted the
SelectCellrendering to handle null/empty values, and updated icon helpers to tolerate nullable inputs.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/db/schema.ts | Makes several skaters columns nullable by removing notNull()/defaults. |
| src/app/data-grid-live/lib/validation.ts | Updates Zod schemas to accept nullable enums/numbers for the skater model. |
| src/components/data-grid/data-grid-cell-variants.tsx | Tweaks SelectCell to display empty state when the cell has no value. |
| src/app/lib/utils.ts | Makes stance/style/status icon helpers tolerate nullable inputs. |
| src/app/data-grid-live/components/data-grid-live-demo.tsx | Creates new rows with nullable select/number fields set to null. |
| src/app/data-grid-multiplayer/components/data-grid-multiplayer-demo.tsx | Same nullable-row creation updates for the multiplayer demo. |
| public/r/data-grid.json | Updates the registry snapshot for the modified data-grid cell variants file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.