Repository navigation
fix(data-grid): fix cell clearing - #1140
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes data-grid cell clearing so that select-variant cells are cleared to null (consistent with other parts of the grid logic) and centralizes “empty value” computation via getEmptyCellValue, which is then reused by the context-menu clear action.
Changes:
- Update
getEmptyCellValueto returnnullforselectvariants. - Refactor context-menu “Clear” to call
getEmptyCellValueinstead of duplicating variant logic. - Update the component/library registry snapshot (
public/r/data-grid.json) to match the source changes.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/lib/data-grid.ts | Extends getEmptyCellValue so select clears to null. |
| src/components/data-grid/data-grid-context-menu.tsx | Uses getEmptyCellValue when clearing selected cells. |
| public/r/data-grid.json | Updates stored source snapshots to reflect the new logic/imports. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.