Repository navigation
fix(registry): make installed items typecheck - #1151
Merged
Merged
Conversation
Move IconPlaceholder under registry/icons so the CLI can strip it, declare zod and dnd-kit deps, and accept an optional dir override on Base UI. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The changed import paths, dependency declarations, and Base UI direction wrapper are consistent with the registry build flow.
Review effort: Lite
Findings: None
What changed in this PR
Updates registry imports and dependency detection so generated components typecheck when installed via the CLI.
Changes:
- Relocates
IconPlaceholderunderregistry/icons. - Adds automatic detection for dnd-kit and zod dependencies.
- Adds Base UI direction override support and normalizes imports.
| File | Description |
|---|---|
src/registry/icons/icon-placeholder.tsx |
Documents the CLI-strip location. |
src/registry/bases/radix/ui/sortable.tsx |
Reorders the dnd-kit import. |
src/registry/bases/radix/ui/faceted.tsx |
Updates the icon import path. |
src/registry/bases/radix/components/data-table/* |
Updates IconPlaceholder imports. |
src/registry/bases/radix/components/data-grid/* |
Updates IconPlaceholder imports. |
src/registry/bases/base/ui/faceted.tsx |
Updates the icon import path. |
src/registry/bases/base/ui/direction.tsx |
Adds an optional direction override. |
src/registry/bases/base/components/data-table/* |
Updates IconPlaceholder imports. |
src/registry/bases/base/components/data-grid/* |
Updates IconPlaceholder imports. |
scripts/build-registry.ts |
Detects dnd-kit and zod imports. |
registry.json |
Declares required zod and dnd-kit dependencies. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves IconPlaceholder under registry/icons so the CLI can strip it, declares zod and dnd-kit deps, and accepts an optional dir override on Base UI.