Repository navigation
chore(registry): cleanup styles - #1154
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
registry/bases.ts does not typecheck, and the unconstrained rewrite breaks legacy style and style-index requests.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Cleans up registry style/base metadata and updates registry generation, routing, and script configuration.
Changes:
- Moves style and base definitions into
registry/. - Generates base/style combinations and updates published style IDs.
- Adds a dedicated scripts TypeScript configuration and adjusts routing defaults.
| File | Description |
|---|---|
tsconfig.scripts.json |
Adds script/registry compiler settings. |
src/registry/styles.ts |
Removes the old shared style definitions. |
scripts/clean-registry.ts |
Cleans generated files for base/style combinations. |
scripts/build-registry.ts |
Builds registry output for each base and style. |
registry/styles.tsx |
Adds style metadata and icons. |
registry/bases.ts |
Adds base metadata. |
public/r/styles/index.json |
Updates published style IDs. |
package.json |
Uses the dedicated scripts config. |
next.config.ts |
Updates registry rewrites and component redirects. |
components.json |
Changes the configured shadcn style. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+24
to
25
| source: "/r/:style/:name.json", | ||
| destination: "/r/styles/:style/:name.json", |
Comment on lines
+5
to
+7
| import type { RegistryItem } from "shadcn/schema"; | ||
|
|
||
| export const BASES: RegistryItem[] = [ |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.