Repository navigation
fix(data-grid): exclude select column from cmd+a selection - #1156
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Range expansion still uses unfiltered column IDs and can reselect non-navigable cells.
Review effort: Lite
Findings: None
What changed in this PR
Updates data-grid selection to exclude non-navigable utility columns from bulk and row selections.
Changes:
- Uses navigable columns for Cmd+A and row selection.
- Adds regression coverage for select/actions columns.
| File | Summary |
|---|---|
src/registry/bases/radix/hooks/use-data-grid.ts |
Excludes non-navigable columns from selections. |
src/registry/bases/base/hooks/use-data-grid.ts |
Mirrors the selection updates. |
src/hooks/test/use-data-grid.test.tsx |
Adds selection regression tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.