Repository navigation
fix(data-table): add fixed-table layout to prevent column layout shift - #1166
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
sadmann7
changed the title
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
CSS variable names can collide for distinct valid column IDs, producing incorrect widths and offsets.
Review effort: Balanced
Findings: 1
What changed in this PR
Adds fixed-layout sizing to prevent data-table column shifts.
Changes:
- Centralizes column widths and pinned offsets as CSS variables.
- Applies fixed table layout and cell clipping in both variants.
- Adjusts task-table pinning and column sizes.
| File | Description |
|---|---|
src/lib/data-table-utils.ts |
Adds shared sizing and offset styles. |
src/registry/bases/base/components/data-table/data-table.tsx |
Applies fixed layout to the base variant. |
src/registry/bases/radix/components/data-table/data-table.tsx |
Mirrors fixed layout in the radix variant. |
src/app/components/tasks-table.tsx |
Pins the selection column. |
src/app/components/tasks-table-columns.tsx |
Adjusts cell truncation and widths. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.