Repository navigation
feat(data-table): refactor url filter and add launch - #1168
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
URL synchronization, filter ordering, date handling, and reduced-motion issues remain unresolved.
Review effort: Balanced
Findings: 7
Open (7)
What changed in this PR
Refactors data-table URL filters into compact per-column parameters and adds a self-playing launch demo with expanded automated testing.
Changes:
- Adds compact filter parsing, calendar-date handling, and shared column configuration.
- Synchronizes filtering changes across Base and Radix variants.
- Adds the launch demo, Playwright coverage, and recording support.
| File | Description |
|---|---|
vitest.config.ts |
Switches tests to Happy DOM. |
src/registry/bases/radix/hooks/use-data-table.ts |
Refactors Radix URL-state synchronization. |
src/registry/bases/radix/components/data-table/data-table-slider-filter.tsx |
Supports open decimal ranges. |
src/registry/bases/radix/components/data-table/data-table-range-filter.tsx |
Preserves numeric input values. |
src/registry/bases/radix/components/data-table/data-table-filter-menu.tsx |
Adopts renamed filter utilities. |
src/registry/bases/radix/components/data-table/data-table-faceted-filter.tsx |
Renames filter option type. |
src/registry/bases/radix/components/data-table/data-table-command-filter-menu.tsx |
Updates command-filter utilities. |
src/registry/bases/base/hooks/use-data-table.ts |
Refactors Base URL-state synchronization. |
src/registry/bases/base/components/data-table/data-table-slider-filter.tsx |
Supports open decimal ranges. |
src/registry/bases/base/components/data-table/data-table-range-filter.tsx |
Preserves numeric input values. |
src/registry/bases/base/components/data-table/data-table-filter-menu.tsx |
Adopts renamed filter utilities. |
src/registry/bases/base/components/data-table/data-table-faceted-filter.tsx |
Renames filter option type. |
src/registry/bases/base/components/data-table/data-table-command-filter-menu.tsx |
Updates command-filter utilities. |
src/lib/test/data-table.test.ts |
Tests parsing and filtering behavior. |
src/lib/site.ts |
Splits site configuration into constants. |
src/lib/parsers.ts |
Implements compact URL filter parsers. |
src/lib/data-table-utils.ts |
Adds filter normalization and date utilities. |
src/lib/data-table-types.ts |
Adds typed column configuration APIs. |
src/lib/data-table-filters.ts |
Updates client-side filter evaluation. |
src/lib/data-table-features.ts |
Uses normalized plain-filter helpers. |
src/hooks/test/use-data-table.test.tsx |
Tests URL-backed table state. |
src/hooks/test/use-data-grid.test.tsx |
Simplifies DOM test mocks. |
src/env.ts |
Defines validated environment variables. |
src/db/index.ts |
Updates environment import. |
src/components/tailwind-indicator.tsx |
Updates environment import. |
src/components/layouts/site-header.tsx |
Uses exported site constants. |
src/components/layouts/mobile-nav.tsx |
Uses exported navigation links. |
src/app/sitemap.ts |
Uses site constants for sitemap entries. |
src/app/robots.ts |
Uses the site URL constant. |
src/app/page.tsx |
Uses unified column configuration. |
src/app/manifest.ts |
Uses site metadata constants. |
src/app/lib/validations.ts |
Defines shared task column configuration. |
src/app/lib/queries.ts |
Types queries from column configuration. |
src/app/lib/filter-columns.ts |
Updates server-side date and range filters. |
src/app/layout.tsx |
Uses site metadata constants. |
src/app/launch/page.tsx |
Adds the launch route. |
src/app/launch/lib/data.ts |
Provides deterministic launch-demo data. |
src/app/launch/launch.css |
Adds launch animations and styling. |
src/app/launch/components/launch-scenes.tsx |
Defines launch story scenes. |
src/app/launch/components/launch-director.tsx |
Implements scripted camera and cursor controls. |
src/app/launch/components/launch-demo.tsx |
Implements the launch timeline and demo. |
src/app/launch/components/launch-columns.tsx |
Defines launch table columns. |
src/app/components/test/tasks-table-columns.test.ts |
Verifies client/server column parity. |
src/app/components/tasks-table.tsx |
Reuses shared default sorting. |
src/app/components/tasks-table-columns.tsx |
Derives options from shared configuration. |
pnpm-lock.yaml |
Locks Playwright and Happy DOM dependencies. |
playwright.record.config.ts |
Configures launch recording. |
playwright.config.ts |
Configures browser E2E tests. |
package.json |
Adds Playwright scripts and dependencies. |
next.config.ts |
Updates environment import. |
e2e/record-launch.spec.ts |
Captures and encodes the launch demo. |
e2e/data-table.spec.ts |
Tests URL filtering end to end. |
drizzle.config.ts |
Updates environment import. |
.oxlintrc.json |
Updates the allowed environment import. |
.gitignore |
Ignores E2E and recording artifacts. |
.github/workflows/code-check.yml |
Adds database-backed E2E CI. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.