test(data-table): cover filters, parsing, and the hook - #1169
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Two live-clock date tests can fail nondeterministically around midnight or daylight-saving transitions.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Expands automated coverage for data-table parsing, filtering, utilities, table behavior, and URL-synchronized hooks.
Changes:
- Adds comprehensive client and SQL filter tests.
- Covers parsing, serialization, sorting, faceting, and layout utilities.
- Extends
useDataTableURL-state tests.
| File | Description |
|---|---|
src/lib/test/data-table.test.ts |
Extends parser and query tests. |
src/lib/test/data-table-utils.test.ts |
Adds utility coverage. |
src/lib/test/data-table-table.test.tsx |
Tests filtering, faceting, state, and layout. |
src/lib/test/data-table-filters.test.ts |
Tests client-side filter matching. |
src/hooks/test/use-data-table.test.tsx |
Extends hook and URL synchronization tests. |
src/app/lib/test/filter-columns.test.ts |
Tests generated SQL filter conditions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.