Repository navigation
refactor(data-table): refactor components to support rtl - #1171
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Physical left/right APIs are incorrectly converted to logical edges in drawer, sheet, and select styling.
Review effort: Balanced
Findings: 4
Open (4)
What changed in this PR
Adds RTL support across base and Radix UI primitives and data-table components.
Changes:
- Replaces physical spacing/alignment utilities with logical equivalents.
- Updates directional icons, overlays, menus, calendars, and data tables.
- Enables RTL generation and updates
react-day-picker.
| File | Description |
|---|---|
src/registry/bases/radix/ui/tooltip.tsx |
Adds logical tooltip spacing. |
src/registry/bases/radix/ui/toggle.tsx |
Adds logical icon padding. |
src/registry/bases/radix/ui/toggle-group.tsx |
Refactors grouped-item RTL styling. |
src/registry/bases/radix/ui/textarea.tsx |
Normalizes React import. |
src/registry/bases/radix/ui/table.tsx |
Adds logical alignment and padding. |
src/registry/bases/radix/ui/sonner.tsx |
Reorders icon imports. |
src/registry/bases/radix/ui/sheet.tsx |
Updates sheet RTL styling. |
src/registry/bases/radix/ui/separator.tsx |
Normalizes React import. |
src/registry/bases/radix/ui/select.tsx |
Adds RTL select positioning. |
src/registry/bases/radix/ui/popover.tsx |
Normalizes React import. |
src/registry/bases/radix/ui/label.tsx |
Normalizes React import. |
src/registry/bases/radix/ui/input.tsx |
Normalizes React import. |
src/registry/bases/radix/ui/input-group.tsx |
Adds logical spacing. |
src/registry/bases/radix/ui/dropdown-menu.tsx |
Adds RTL menu layout. |
src/registry/bases/radix/ui/drawer.tsx |
Updates drawer RTL positioning. |
src/registry/bases/radix/ui/dialog.tsx |
Adds RTL centering and controls. |
src/registry/bases/radix/ui/command.tsx |
Adds logical command spacing. |
src/registry/bases/radix/ui/checkbox.tsx |
Adjusts field focus styling. |
src/registry/bases/radix/ui/calendar.tsx |
Adds RTL range and navigation styling. |
src/registry/bases/radix/ui/button.tsx |
Adds logical icon padding. |
src/registry/bases/radix/ui/badge.tsx |
Adds logical icon padding. |
src/registry/bases/radix/components/data-table/data-table.tsx |
Simplifies RTL cell behavior. |
src/registry/bases/radix/components/data-table/data-table-column-header.tsx |
Simplifies RTL menu overrides. |
src/registry/bases/base/ui/tooltip.tsx |
Adds logical tooltip placement. |
src/registry/bases/base/ui/table.tsx |
Adds logical alignment and padding. |
src/registry/bases/base/ui/switch.tsx |
Reverses thumb translation in RTL. |
src/registry/bases/base/ui/select.tsx |
Adds logical select layout. |
src/registry/bases/base/ui/scroll-area.tsx |
Uses a logical scrollbar border. |
src/registry/bases/base/ui/popover.tsx |
Adds logical popup animation direction. |
src/registry/bases/base/ui/input-group.tsx |
Adds logical spacing. |
src/registry/bases/base/ui/hover-card.tsx |
Adds logical popup animation direction. |
src/registry/bases/base/ui/dropdown-menu.tsx |
Adds logical menu layout. |
src/registry/bases/base/ui/drawer.tsx |
Updates drawer RTL positioning. |
src/registry/bases/base/ui/dialog.tsx |
Adds RTL centering and control rendering. |
src/registry/bases/base/ui/command.tsx |
Adds logical command spacing. |
src/registry/bases/base/ui/button.tsx |
Adds logical icon padding. |
src/registry/bases/base/ui/button-group.tsx |
Adds logical grouped borders. |
src/registry/bases/base/ui/badge.tsx |
Adds logical icon padding. |
src/registry/bases/base/ui/avatar.tsx |
Uses logical badge positioning. |
src/registry/bases/base/components/data-table/data-table.tsx |
Simplifies RTL cell behavior. |
src/registry/bases/base/components/data-table/data-table-column-header.tsx |
Simplifies RTL menu overrides. |
pnpm-lock.yaml |
Locks updated calendar dependency. |
package.json |
Updates react-day-picker. |
components.json |
Enables RTL generation. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.