Skip to content

Automatically convert cache_dir string to path in script#24

Merged
ecarrenolozano merged 2 commits intomainfrom
fix/cache-dir-type
Mar 10, 2026
Merged

Automatically convert cache_dir string to path in script#24
ecarrenolozano merged 2 commits intomainfrom
fix/cache-dir-type

Conversation

@ecarrenolozano
Copy link
Member

This pull request updates the logging configuration, improves cache directory handling in the downloader, and updates the sandbox use case to use a new downloader adapter. The main changes focus on standardizing file paths and switching to a new download manager for improved functionality.

Logging configuration updates:

  • Changed log file name in 04_workdir.yaml from my_saezapp_logger.log to app_go_logger.log for clearer identification.
  • Removed the root logger configuration from 04_workdir.yaml to simplify logging setup.

Downloader improvements:

  • Updated ontograph/downloader.py to ensure cache_dir is always a Path object, improving path handling and consistency.

Sandbox use case updates:

  • Modified sandbox/use_case_downloaders.py to use the new DownloadManagerAdapter instead of PoochDownloaderAdapter, and standardized the cache directory path usage throughout the script. [1] [2]

@ecarrenolozano ecarrenolozano self-assigned this Mar 10, 2026
@ecarrenolozano ecarrenolozano added the bug Something isn't working label Mar 10, 2026
@ecarrenolozano ecarrenolozano merged commit 62bb7f7 into main Mar 10, 2026
10 checks passed
@ecarrenolozano ecarrenolozano deleted the fix/cache-dir-type branch March 10, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant