Automatically convert cache_dir string to path in script#24
Merged
ecarrenolozano merged 2 commits intomainfrom Mar 10, 2026
Merged
Automatically convert cache_dir string to path in script#24ecarrenolozano merged 2 commits intomainfrom
ecarrenolozano merged 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the logging configuration, improves cache directory handling in the downloader, and updates the sandbox use case to use a new downloader adapter. The main changes focus on standardizing file paths and switching to a new download manager for improved functionality.
Logging configuration updates:
04_workdir.yamlfrommy_saezapp_logger.logtoapp_go_logger.logfor clearer identification.rootlogger configuration from04_workdir.yamlto simplify logging setup.Downloader improvements:
ontograph/downloader.pyto ensurecache_diris always aPathobject, improving path handling and consistency.Sandbox use case updates:
sandbox/use_case_downloaders.pyto use the newDownloadManagerAdapterinstead ofPoochDownloaderAdapter, and standardized the cache directory path usage throughout the script. [1] [2]