fix: safe-core robustness (multisend recursion, EIP-1271 preimage) + utils cleanup#2512
Merged
Merged
Conversation
safe-core: - MultiSend.from_bytes: decode iteratively instead of recursively. The previous `[tx] + cls.from_bytes(rest)` recursion hit RecursionError and was O(n^2) on large (attacker-controllable) multisend payloads. Behaviour is byte-for-byte identical. utils: - remove_swarm_metadata: strip CBOR metadata generically via its trailing 2-byte length (handles IPFS/bzzr1/solc, not only legacy bzzr0). - bytes_to_float: raise ValueError instead of assert (assert is stripped under python -O). - fast_to_checksum_address / fast_bytes_to_checksum_address: interpolate the offending value into the previously-uninterpolated %s error message.
Uxio0
force-pushed
the
uxio/pla-1544-safe-eth-py-robustness-fixes
branch
from
e48c4d0 to
09e9e37
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e48c4d0d69
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
falvaradorodriguez
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Safe-core robustness fixes plus a small
eth/utils.pycleanup pass, from thesafe-eth-pyreview.Changes
Safe-core
safe/multi_send.py—MultiSend.from_bytesnow decodes iteratively instead of recursively. The old[tx] + cls.from_bytes(rest)blew the stack (RecursionError) and was O(n²) on large, attacker-controllable multisend payloads. Output is byte-for-byte identical.utils cleanup
remove_swarm_metadata— strips CBOR metadata generically via its trailing 2-byte length, so it handles IPFS /bzzr1/solcblobs (Solidity ≥0.5.10), not only legacybzzr0.bytes_to_float— raisesValueErrorinstead ofassert(asserts are stripped underpython -O).fast_to_checksum_address/fast_bytes_to_checksum_address— interpolate the the offending value into the previously-uninterpolated %s error messageCloses PLA-1568