Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add V2 for multisigtransaction and all-transactions endpoints #2417

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

moisses89
Copy link
Member

@moisses89 moisses89 commented Feb 20, 2025

Description

Add V2 endpoint for the new return types on multisigtransaction.

Marking as deprecated the following endpoints

  • GET /api/v1/multisig-transactions/{safe_tx_hash}/
  • DELETE /api/v1/multisig-transactions/{safe_tx_hash}/
  • GET /api/v1/safes/{address}/multisig-transactions/
  • POST /api/v1/safes/{address}/multisig-transactions/
  • GET /api/v1/safes/{address}/all-transactions/

V2 of new endpoints

  • GET /api/v2/multisig-transactions/{safe_tx_hash}/
  • DELETE /api/v2/multisig-transactions/{safe_tx_hash}/
  • GET /api/v2/safes/{address}/multisig-transactions/
  • POST /api/v2/safes/{address}/multisig-transactions/
  • GET /api/v2/safes/{address}/all-transactions/

Version2 types

The endpoints behind version two modify the types int for string for the following properties.

 nonce : <String>
 base_gas : <String>
 safe_tx_gas : <String>

@moisses89 moisses89 requested a review from a team as a code owner February 20, 2025 09:41
@moisses89 moisses89 changed the title Versioning change types on multisigtransaction Add V2 for multisigtransaction and all-transactions endpoints Feb 20, 2025
@moisses89 moisses89 merged commit a01668f into main Feb 20, 2025
5 checks passed
@moisses89 moisses89 deleted the versioning_nonce branch February 20, 2025 13:33
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2025
@JagoFigueroa
Copy link

Looking good to me, will be sure to test them on UI too once the v2 are enabled there too

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants