Miscellaneous "long time" additions #40998
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a polyomino test in this file that triggers a "slow doctest" warning on the CI, coming in at 10.79s CPU. On my (slow) machine it takes 12.2s, which is faster than I expected, but is still slow enough that we should mark it "long time" to avoid warnings.
…ime" One projective_meridians() test in this file is just barely triggering a "slow doctest" warning on the CI, at 5.04s cpu. On my (slow) machine it takes a bit longer, around 6.5s cpu. This is longer than the recommended length for a doctest in any case, so we mark it "long time" to avoid warnings.
There's a series of tests in this file that set an alarm interrupt, and then attempt to express a polynomial in terms of the generators of an ideal (to which it belongs). This is taking around 5s on the CI, and as a result, is sometimes raising "slow doctest" warnings. On my (slow) machine, the lift takes about 15s, and the added 0.5s alarm increases that. We mark all of these tests "long time" to be on the safe side.
The line, sage: G1 = SymQ3.AffineGrothendieckPolynomial([1],6) is triggering slow doctest warnings on the CI, and takes over 50s to complete on my (slow) machine. Let's mark it "long time" to avoid the warnings.
Ine test in this file is causing a "slow doctest" warning on the
CI. On my (much slower) machine, it takes over 40s:
File "src/sage/schemes/elliptic_curves/isogeny_class.py", line 1412,
in sage.schemes.elliptic_curves.isogeny_class.?
Warning: slow doctest:
[phi.degree() for phi in E3.isogenies_prime_degree()]
Test ran for 43.57s cpu, 43.56s wall
Check ran for 0.00s cpu, 0.00s wall
We mark it "long time" to avoid the warnings (and because it takes a
long time).
|
Documentation preview for this PR (built with commit e9b7ad1; changes) is ready! 🎉 |
|
Cool, thank you. In another six months I may actually have fixed (or hidden) all of these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few random warnings I picked out of the CI, all confirmed locally.