Skip to content

fix: icon placement in rtl layouts #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JunkFood02 wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

fix: icon placement in rtl layouts #33

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a35f21e
fix: icon placement in rtl layouts
JunkFood02 Oct 2, 2024
0867761
test: add test for rtl
JunkFood02 Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions library/src/commonMain/kotlin/me/saket/swipe/SwipeableActionsBox.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,11 @@ private fun ActionIconBox(
layout(width = placeable.width, height = placeable.height) {
// Align icon with the left/right edge of the content being swiped.
val iconOffset = if (action.isOnRightSide) constraints.maxWidth + offset else offset - placeable.width
placeable.placeRelative(x = iconOffset.roundToInt(), y = 0)
placeable.place(x = iconOffset.roundToInt(), y = 0)
}
}
.background(color = backgroundColor),
horizontalArrangement = if (action.isOnRightSide) Arrangement.Start else Arrangement.End,
horizontalArrangement = if (action.isOnRightSide) Arrangement.Absolute.Left else Arrangement.Absolute.Right,
Copy link
Owner

@saket saket Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a screenshot test to verify this? Here are some examples: https://github.com/saket/swipe/blob/trunk/library/src/test/kotlin/me/saket/swipe/SwipeableActionsBoxTest.kt#L43

Copy link
Author

@JunkFood02 JunkFood02 Nov 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I did this correctly. Please take another look!

Copy link
Owner

@saket saket Nov 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep this looks good, thank you!

verticalAlignment = Alignment.CenterVertically,
) {
content()
Expand Down