Skip to content

@W-15246641 : fix for Disappearing tooltip button content #3171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

@W-15246641 : fix for Disappearing tooltip button content #3171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f22fca3
@W-15246641 : fix for Disappearing tooltip button content
bdewangan Jan 16, 2025
90b57ce
@W-15246641 : fix for Disappearing tooltip button content
bdewangan Jan 16, 2025
226e1d3
@W-15246641 : fix for Disappearing tooltip button content
bdewangan Jan 16, 2025
03b2f97
@W-15246641 : fix for Disappearing tooltip button content
bdewangan Jan 16, 2025
b81c048
@W-15246641 : fix for Disappearing tooltip button content
bdewangan Jan 16, 2025
fd4c162
@W-15246641 : fix for Disappearing tooltip button content
bdewangan Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions components/builder-header/__docs__/__snapshots__/storybook-stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,6 +404,7 @@ exports[`DOM snapshots SLDSBuilderHeader After Successful Save 1`] = `
<div>
<div
className="slds-tooltip-trigger"
onMouseLeave={[Function]}
style={
Object {
"display": "inline-block",
Expand All @@ -413,10 +414,8 @@ exports[`DOM snapshots SLDSBuilderHeader After Successful Save 1`] = `
>
<span
className="slds-color__text_gray-10 slds-align-middle slds-m-right_small"
onBlur={[Function]}
onFocus={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
tabIndex={0}
>
Saved 5 mins ago
Expand Down Expand Up @@ -948,6 +947,7 @@ exports[`DOM snapshots SLDSBuilderHeader Base with Page Type Editable 1`] = `
>
<div
className="slds-tooltip-trigger"
onMouseLeave={[Function]}
style={
Object {
"display": "inline-block",
Expand All @@ -958,11 +958,9 @@ exports[`DOM snapshots SLDSBuilderHeader Base with Page Type Editable 1`] = `
<button
className="slds-button slds-button_icon-inverse slds-button_reset"
disabled={false}
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
style={
Object {
"verticalAlign": "middle",
Expand Down Expand Up @@ -1029,6 +1027,7 @@ exports[`DOM snapshots SLDSBuilderHeader Base with Page Type Editable 1`] = `
>
<div
className="slds-tooltip-trigger"
onMouseLeave={[Function]}
style={
Object {
"display": "inline-block",
Expand All @@ -1039,11 +1038,9 @@ exports[`DOM snapshots SLDSBuilderHeader Base with Page Type Editable 1`] = `
<button
className="slds-button slds-button_icon-inverse slds-button_reset"
disabled={false}
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
style={
Object {
"verticalAlign": "middle",
Expand Down Expand Up @@ -2584,6 +2581,7 @@ exports[`DOM snapshots SLDSBuilderHeader Failed Save 1`] = `
<div>
<div
className="slds-tooltip-trigger"
onMouseLeave={[Function]}
style={
Object {
"display": "inline-block",
Expand All @@ -2593,10 +2591,8 @@ exports[`DOM snapshots SLDSBuilderHeader Failed Save 1`] = `
>
<button
className="slds-button slds-color__text_gray-10 slds-align-middle slds-m-right_x-small"
onBlur={[Function]}
onFocus={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
type="button"
>
Saved 45 mins ago
Expand Down
69 changes: 37 additions & 32 deletions components/combobox/__docs__/__snapshots__/storybook-stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -880,6 +880,7 @@ exports[`DOM snapshots SLDSCombobox Base Inline Help 1`] = `
</label>
<div
className="slds-tooltip-trigger slds-form-element__icon"
onMouseLeave={[Function]}
style={
Object {
"display": "inline-block",
Expand All @@ -892,11 +893,9 @@ exports[`DOM snapshots SLDSCombobox Base Inline Help 1`] = `
aria-disabled={true}
className="slds-button slds-button_icon"
disabled={false}
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
type="button"
>
<svg
Expand Down Expand Up @@ -1671,6 +1670,7 @@ exports[`DOM snapshots SLDSCombobox Base Menu Item Disabled With Tooltip Open 1`
>
<div
className="slds-tooltip-trigger"
onMouseLeave={[Function]}
style={
Object {
"display": "inline-block",
Expand All @@ -1685,11 +1685,9 @@ exports[`DOM snapshots SLDSCombobox Base Menu Item Disabled With Tooltip Open 1`
aria-selected={false}
className="slds-media slds-listbox__option slds-listbox__option_entity slds-listbox__option_has-meta"
id="combobox-base-listbox-option-4"
onBlur={[Function]}
onClick={null}
onFocus={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
role="option"
style={
Object {
Expand Down Expand Up @@ -1741,22 +1739,26 @@ exports[`DOM snapshots SLDSCombobox Base Menu Item Disabled With Tooltip Open 1`
</span>
</span>
<div
className="absolute-positioned slds-nubbin_bottom slds-popover slds-popover_tooltip"
id="combobox-base-listbox-option-help-4"
onKeyDown={[Function]}
role="tooltip"
style={
Object {
"outline": 0,
"pointerEvents": "none",
"position": "absolute",
}
}
onMouseLeave={[Function]}
>
<div
className="slds-popover__body"
className="absolute-positioned slds-nubbin_bottom slds-popover slds-popover_tooltip"
id="combobox-base-listbox-option-help-4"
onKeyDown={[Function]}
role="tooltip"
style={
Object {
"outline": 0,
"pointerEvents": "none",
"position": "absolute",
}
}
>
This account has been removed from the system.
<div
className="slds-popover__body"
>
This account has been removed from the system.
</div>
</div>
</div>
</div>
Expand Down Expand Up @@ -1818,6 +1820,7 @@ exports[`DOM snapshots SLDSCombobox Base Menu Item Disabled With Tooltip Open 1`
>
<div
className="slds-tooltip-trigger"
onMouseLeave={[Function]}
style={
Object {
"display": "inline-block",
Expand All @@ -1832,11 +1835,9 @@ exports[`DOM snapshots SLDSCombobox Base Menu Item Disabled With Tooltip Open 1`
aria-selected={false}
className="slds-media slds-listbox__option slds-listbox__option_entity slds-listbox__option_has-meta"
id="combobox-base-listbox-option-6"
onBlur={[Function]}
onClick={null}
onFocus={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
role="option"
style={
Object {
Expand Down Expand Up @@ -1888,22 +1889,26 @@ exports[`DOM snapshots SLDSCombobox Base Menu Item Disabled With Tooltip Open 1`
</span>
</span>
<div
className="absolute-positioned slds-nubbin_bottom slds-popover slds-popover_tooltip"
id="combobox-base-listbox-option-help-6"
onKeyDown={[Function]}
role="tooltip"
style={
Object {
"outline": 0,
"pointerEvents": "none",
"position": "absolute",
}
}
onMouseLeave={[Function]}
>
<div
className="slds-popover__body"
className="absolute-positioned slds-nubbin_bottom slds-popover slds-popover_tooltip"
id="combobox-base-listbox-option-help-6"
onKeyDown={[Function]}
role="tooltip"
style={
Object {
"outline": 0,
"pointerEvents": "none",
"position": "absolute",
}
}
>
You don't have permission to access this account.
<div
className="slds-popover__body"
>
You don't have permission to access this account.
</div>
</div>
</div>
</div>
Expand Down
8 changes: 4 additions & 4 deletions components/date-picker/__tests__/__snapshots__/datepicker.dom-snapshot-test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1923,7 +1923,7 @@ exports[`Datepicker
required={false}
role="textbox"
type="text"
value="2014"
value=""
/>
<span
className="slds-icon_container slds-input__icon slds-input__icon_right"
Expand Down Expand Up @@ -2783,7 +2783,7 @@ exports[`Datepicker Default DOM Snapshot 1`] = `
required={false}
role="textbox"
type="text"
value="2014"
value=""
/>
<span
className="slds-icon_container slds-input__icon slds-input__icon_right"
Expand Down Expand Up @@ -3486,7 +3486,7 @@ exports[`Datepicker Default HTML Snapshot 1`] = `
<div class=\\"slds-form-element__control\\">
<div class=\\"slds-combobox_container\\">
<div class=\\"slds-combobox slds-dropdown-trigger slds-dropdown-trigger_click ignore-react-onclickoutside slds-shrink-none\\" role=\\"combobox\\" aria-expanded=\\"false\\" aria-haspopup=\\"listbox\\">
<div class=\\"slds-combobox__form-element slds-input-has-icon slds-input-has-icon_right\\" role=\\"none\\"><input type=\\"text\\" autoComplete=\\"off\\" class=\\"slds-input slds-combobox__input\\" id=\\"sample-datepicker-year-picklist\\" placeholder=\\"Select an Option\\" readonly=\\"\\" role=\\"textbox\\" aria-autocomplete=\\"list\\" value=\\"2014\\" /><span class=\\"slds-icon_container slds-input__icon slds-input__icon_right\\"><svg aria-hidden=\\"true\\" class=\\"slds-icon slds-icon_x-small slds-icon-text-default\\">
<div class=\\"slds-combobox__form-element slds-input-has-icon slds-input-has-icon_right\\" role=\\"none\\"><input type=\\"text\\" autoComplete=\\"off\\" class=\\"slds-input slds-combobox__input\\" id=\\"sample-datepicker-year-picklist\\" placeholder=\\"Select an Option\\" readonly=\\"\\" role=\\"textbox\\" aria-autocomplete=\\"list\\" value=\\"\\" /><span class=\\"slds-icon_container slds-input__icon slds-input__icon_right\\"><svg aria-hidden=\\"true\\" class=\\"slds-icon slds-icon_x-small slds-icon-text-default\\">
<use href=\\"/assets/icons/utility-sprite/svg/symbols.svg#down\\"></use>
</svg></span></div>
</div>
Expand Down Expand Up @@ -3749,7 +3749,7 @@ exports[`ErrorPicker 1`] = `
required={false}
role="textbox"
type="text"
value="2014"
value=""
/>
<span
className="slds-icon_container slds-input__icon slds-input__icon_right"
Expand Down
36 changes: 19 additions & 17 deletions components/input/__docs__/__snapshots__/storybook-stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1608,6 +1608,7 @@ exports[`DOM snapshots SLDSInput Field Level Help 1`] = `
</label>
<div
className="slds-tooltip-trigger slds-form-element__icon"
onMouseLeave={[Function]}
style={
Object {
"display": "inline-block",
Expand All @@ -1620,11 +1621,9 @@ exports[`DOM snapshots SLDSInput Field Level Help 1`] = `
aria-disabled={true}
className="slds-button slds-button_icon"
disabled={false}
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
type="button"
>
<svg
Expand Down Expand Up @@ -1679,6 +1678,7 @@ exports[`DOM snapshots SLDSInput Field Level Help, Tooltip Open 1`] = `
</label>
<div
className="slds-tooltip-trigger slds-form-element__icon"
onMouseLeave={[Function]}
style={
Object {
"display": "inline-block",
Expand All @@ -1692,11 +1692,9 @@ exports[`DOM snapshots SLDSInput Field Level Help, Tooltip Open 1`] = `
aria-disabled={true}
className="slds-button slds-button_icon"
disabled={false}
onBlur={[Function]}
onClick={[Function]}
onFocus={[Function]}
onMouseEnter={[Function]}
onMouseLeave={[Function]}
type="button"
>
<svg
Expand All @@ -1714,22 +1712,26 @@ exports[`DOM snapshots SLDSInput Field Level Help, Tooltip Open 1`] = `
</span>
</button>
<div
className="absolute-positioned slds-nubbin_bottom-left slds-popover slds-popover_tooltip"
id="field-level-help-tooltip"
onKeyDown={[Function]}
role="tooltip"
style={
Object {
"outline": 0,
"pointerEvents": "none",
"position": "absolute",
}
}
onMouseLeave={[Function]}
>
<div
className="slds-popover__body"
className="absolute-positioned slds-nubbin_bottom-left slds-popover slds-popover_tooltip"
id="field-level-help-tooltip"
onKeyDown={[Function]}
role="tooltip"
style={
Object {
"outline": 0,
"pointerEvents": "none",
"position": "absolute",
}
}
>
Some helpful information
<div
className="slds-popover__body"
>
Some helpful information
</div>
</div>
</div>
</div>
Expand Down
Loading