Skip to content

Update dependencies, continue HTTP review #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update dependencies, continue HTTP review #385

wants to merge 4 commits into from

Conversation

lkrms
Copy link
Collaborator

@lkrms lkrms commented May 21, 2025

No description provided.

lkrms added 4 commits May 21, 2025 13:59
- Split `AccessToken` into `GenericCredential`, `GenericToken` and
  `OAuth2AccessToken`, replacing public properties with getters
- Rename `OAuth2GrantType` to `HasGrantType`; access its constants
  (now with `GRANT_` prefixes) via its implementations; add missing
  grants, incl. `device_code` for planned device flow support
- Remove redundant `OAuth2Flow` (grants and flows are equivalent)
- Add `HasResponseType` for values passed to the authorization endpoint,
  incl. for OpenID Connect flows
Copy link

codecov bot commented May 21, 2025

Codecov Report

Attention: Patch coverage is 60.60606% with 26 lines in your changes missing coverage. Please review.

Project coverage is 73.81%. Comparing base (ee9034a) to head (ed6ba53).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/Toolkit/Http/OAuth2/OAuth2Client.php 0.00% 23 Missing ⚠️
src/Toolkit/Curler/Curler.php 72.72% 3 Missing ⚠️
Additional details and impacted files
Components Coverage Δ
Cache 100.00% <ø> (ø)
Cli 76.45% <ø> (ø)
Collections 84.79% <ø> (ø)
Console 85.55% <ø> (ø)
Container 75.78% <ø> (ø)
Contracts ∅ <ø> (∅)
Core 81.90% <100.00%> (-0.01%) ⬇️
Curler 64.50% <72.72%> (+0.03%) ⬆️
Db 0.00% <ø> (ø)
Http 81.09% <54.90%> (+0.04%) ⬆️
Iterators 82.31% <ø> (ø)
PHPDoc 91.20% <ø> (ø)
PHPStan 99.32% <ø> (ø)
Polyfills 100.00% <ø> (ø)
Sli 40.66% <ø> (ø)
Sync 66.44% <100.00%> (+0.07%) ⬆️
Testing 77.16% <ø> (ø)
Utils 93.41% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant