Add some iterator tests #101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hu13
changed the base branch from
feature/slice-iterable-testing-prototype
to
main
hu13
changed the base branch from
main
to
feature/slice-iterable-testing-prototype
Author
|
@jagobagascon do you think we can get this merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the start index to 0 because I expect the iterator to be able to getCurrent() element if one exists before calling moveNext()?
I also add bound check to getCurrent().
Lastly, getMany() will advance the index beyond the last element if the requested amount is the entire list to mark that there are no items left.